change host file entry for Mac #39760

nbon12 · 2023-03-02T16:55:35Z

For mac, the following parts of the documentation did not work for me:

Add the following line to the bottom of the /etc/hosts file on
your computer (you will need administrator access):

172.17.0.15 hello-world.info

Instead, my host file needed to point to 127.0.0.1 (localhost), and Mac users need to run minikube tunnel

This works on Mac with minikube running on a Docker back-end:

127.0.0.1 hello-world.info

followed by running the command minikube tunnel

See this comment: kubernetes/minikube#13510 (comment)

For mac, the following parts of the documentation did not work for me: > 1. Add the following line to the bottom of the `/etc/hosts` file on > your computer (you will need administrator access): > ```none > 172.17.0.15 hello-world.info > ``` Instead, my host file needed to point to 127.0.0.1 (localhost) This works on Mac: > ```none > 127.0.0.1 hello-world.info > ``` followed by running the command `minikube tunnel`

linux-foundation-easycla · 2023-03-02T16:55:39Z

The committers listed above are authorized under a signed CLA.

✅ login: nbon12 / name: Nick Bonilla (7dcb1e6, 355a8bf)

k8s-ci-robot · 2023-03-02T16:55:42Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign onlydole for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/en/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-03-02T16:55:44Z

Welcome @nbon12!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

netlify · 2023-03-02T17:07:44Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`7dcb1e6`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6400d5095c7ea400091f5470
😎 Deploy Preview	https://deploy-preview-39760--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim

My thoughts

content/en/docs/tasks/access-application-cluster/ingress-minikube.md

netlify · 2023-03-02T22:46:05Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`7e8eda6`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64025e29e2038200073fbb71
😎 Deploy Preview	https://deploy-preview-39760--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…ube.md Co-authored-by: Tim Bannister <tim@scalefactory.com>

k8s-ci-robot · 2023-03-31T23:35:04Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kbhawkey · 2023-05-09T01:51:56Z

Preview:
https://deploy-preview-39760--kubernetes-io-main-staging.netlify.app/docs/tasks/access-application-cluster/ingress-minikube/#create-an-ingress

@nbon12 Can you rebase your changes?

sftim · 2023-06-28T21:53:49Z

content/en/docs/tasks/access-application-cluster/ingress-minikube.md

   {{< /note >}}
+
+   {{< note >}}


Suggested change

{{< /note >}}

{{< note >}}

sftim

macOS users: please review this and comment if it works OK for you.

divya-mohan0209 · 2023-08-17T02:48:35Z

Hello @nbon12 , thank you for these changes & for your initiative! Please could you let us know if you have the bandwidth to continue working on the PR & address the merge conflict? Failing to respond by 25th August, 2023 will result in closure of this PR.

reylejano · 2023-09-08T18:14:42Z

Hi @nbon12 ,
I'm closing this PR because it needs rebase due to a merge conflict and it has not moved forward.
When you have cycles to rebase, feel free to reopen the PR with /reopen in a comment
/close

k8s-ci-robot · 2023-09-08T18:14:47Z

@reylejano: Closed this PR.

In response to this:

Hi @nbon12 ,
I'm closing this PR because it needs rebase due to a merge conflict and it has not moved forward.
When you have cycles to rebase, feel free to reopen the PR with /reopen in a comment
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2023

k8s-ci-robot requested a review from nate-double-u March 2, 2023 16:55

k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 2, 2023

k8s-ci-robot requested a review from sftim March 2, 2023 16:55

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 2, 2023

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 2, 2023

Clarify the docker back-end

355a8bf

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 2, 2023

nbon12 marked this pull request as ready for review March 2, 2023 17:02

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2023

k8s-ci-robot requested review from kbhawkey and shannonxtreme March 2, 2023 17:02

sftim reviewed Mar 2, 2023

View reviewed changes

content/en/docs/tasks/access-application-cluster/ingress-minikube.md Outdated Show resolved Hide resolved

content/en/docs/tasks/access-application-cluster/ingress-minikube.md Outdated Show resolved Hide resolved

nbon12 and others added 2 commits March 3, 2023 15:52

Update content/en/docs/tasks/access-application-cluster/ingress-minik…

44f9665

…ube.md Co-authored-by: Tim Bannister <tim@scalefactory.com>

Update content/en/docs/tasks/access-application-cluster/ingress-minik…

7e8eda6

…ube.md Co-authored-by: Tim Bannister <tim@scalefactory.com>

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2023

sftim reviewed Jun 28, 2023

View reviewed changes

k8s-ci-robot closed this Sep 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change host file entry for Mac #39760

change host file entry for Mac #39760

nbon12 commented Mar 2, 2023

linux-foundation-easycla bot commented Mar 2, 2023 •

edited

Loading

k8s-ci-robot commented Mar 2, 2023

k8s-ci-robot commented Mar 2, 2023

netlify bot commented Mar 2, 2023

sftim left a comment

netlify bot commented Mar 2, 2023 •

edited

Loading

k8s-ci-robot commented Mar 31, 2023

kbhawkey commented May 9, 2023

sftim Jun 28, 2023

sftim left a comment

divya-mohan0209 commented Aug 17, 2023

reylejano commented Sep 8, 2023

k8s-ci-robot commented Sep 8, 2023

change host file entry for Mac #39760

change host file entry for Mac #39760

Conversation

nbon12 commented Mar 2, 2023

linux-foundation-easycla bot commented Mar 2, 2023 • edited Loading

k8s-ci-robot commented Mar 2, 2023

k8s-ci-robot commented Mar 2, 2023

netlify bot commented Mar 2, 2023

✅ Pull request preview available for checking

sftim left a comment

Choose a reason for hiding this comment

netlify bot commented Mar 2, 2023 • edited Loading

✅ Pull request preview available for checking

k8s-ci-robot commented Mar 31, 2023

kbhawkey commented May 9, 2023

sftim Jun 28, 2023

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

divya-mohan0209 commented Aug 17, 2023

reylejano commented Sep 8, 2023

k8s-ci-robot commented Sep 8, 2023

linux-foundation-easycla bot commented Mar 2, 2023 •

edited

Loading

netlify bot commented Mar 2, 2023 •

edited

Loading