Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSIMigrationvSphere doc update #37701

Conversation

divyenpatel
Copy link
Member

Documentation update for CSIMigrationvSphere feature gate.

KEP - kubernetes/enhancements#1491

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Nov 3, 2022
@netlify
Copy link

netlify bot commented Nov 3, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 21cb053
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/636be8f94ba13a000956fa52

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval by writing /assign @natalisucks in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Nov 3, 2022
@k8s-ci-robot k8s-ci-robot requested a review from saad-ali November 3, 2022 18:03
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2022
@divyenpatel
Copy link
Member Author

@sftim @tengqm I have addressed your review comments.

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to delete these lines from the feature gates page:

| `CSIMigrationvSphere` | `false` | Alpha | 1.18 | 1.18 |
| `CSIMigrationvSphere` | `false` | Beta | 1.19 | 1.24 |
| `CSIMigrationvSphere` | `true` | Beta | 1.25 | |

content/en/docs/concepts/storage/volumes.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2022
Co-authored-by: Tim Bannister <tim@scalefactory.com>

Update content/en/docs/reference/command-line-tools-reference/feature-gates.md

Co-authored-by: Tim Bannister <tim@scalefactory.com>

Update content/en/docs/concepts/storage/volumes.md

Co-authored-by: Tim Bannister <tim@scalefactory.com>
@divyenpatel divyenpatel force-pushed the update-vsphere-doc-dev-1.26 branch from 1236ca3 to 21cb053 Compare November 9, 2022 17:52
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2022
@divyenpatel divyenpatel closed this Nov 9, 2022
@divyenpatel
Copy link
Member Author

@sftim I did some mistake in rebase, so created a new PR on the new branch.
Here is the new PR - #37815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants