Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the doc for minDomains to graduate minDomains to beta #35202

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Update the doc for minDomains to graduate minDomains to beta #35202

merged 1 commit into from
Aug 8, 2022

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Jul 20, 2022 •
edited
Loading

We plan to graduate minDomains feature to beta in 1.25.
This PR is to update the doc for preparing it.

Part of: kubernetes/enhancements#3022

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2022
@netlify
Copy link

netlify bot commented Jul 20, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit b26ae49
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62ee0a5a3008910008b0ce03

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 20, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 20, 2022
@sanposhiho sanposhiho mentioned this pull request Jul 20, 2022
Closed
12 tasks
mehabhalodiya
mehabhalodiya reviewed Jul 21, 2022
View reviewed changes
Copy link
Contributor

@mehabhalodiya mehabhalodiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 729667bd071e3e9438db88157aace254e43b35b9

@sanposhiho
Copy link
Member Author

/assign @divya-mohan0209

divya-mohan0209
divya-mohan0209 reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@divya-mohan0209
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@divya-mohan0209 divya-mohan0209 added this to the 1.25 milestone Jul 25, 2022
@cathchu
Copy link
Contributor

cathchu commented Jul 29, 2022

Hey there 👋 @sanposhiho, 1.25 Release Docs Shadow here!

Thanks for filing this placeholder. As a reminder, final docs PRs are due August 9th. Take a look at Documenting a release for additional information for the docs requirement for the release.

Thanks again!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@reylejano
Copy link
Member

/assign @krol3
/cc @kcmartin

@k8s-ci-robot k8s-ci-robot requested a review from kcmartin August 3, 2022 22:22
@alculquicondor
Copy link
Member

/assign
from scheduling

alculquicondor
alculquicondor reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a section topologySpreadConstraints field that still mentions that the feature is alpha.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
@@ -150,7 +150,8 @@ different Kubernetes components.
| `MemoryManager` | `false` | Alpha | 1.21 | 1.21 |
| `MemoryManager` | `true` | Beta | 1.22 | |
| `MemoryQoS` | `false` | Alpha | 1.22 | |
| `MinDomainsInPodTopologySpread` | `false` | Alpha | 1.24 | |
| `MinDomainsInPodTopologySpread` | `false` | Alpha | 1.24 | 1.25 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `MinDomainsInPodTopologySpread` | `false` | Alpha | 1.24 | 1.25 |
| `MinDomainsInPodTopologySpread` | `false` | Alpha | 1.24 | 1.24 |

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2022
@sanposhiho
Copy link
Member Author

@alculquicondor Please retake a look 🙏

alculquicondor
alculquicondor reviewed Aug 8, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from sig scheduling

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 78f9816ba23e882fc90cdf3ec22fe88669c6bca7

@reylejano
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@reylejano
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2846caa into kubernetes:dev-1.25 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@jimangel jimangel Awaiting requested review from jimangel

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@kcmartin kcmartin Awaiting requested review from kcmartin

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@krol3 krol3 Awaiting requested review from krol3

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

Assignees

@alculquicondor alculquicondor

@krol3 krol3

@divya-mohan0209 divya-mohan0209

@reylejano reylejano

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.25
Development

Successfully merging this pull request may close these issues.
8 participants
@sanposhiho @k8s-ci-robot @divya-mohan0209 @cathchu @reylejano @alculquicondor @mehabhalodiya @krol3