Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPIEnums feature is beta in 1.24 #32594

Merged
merged 1 commit into from
Apr 6, 2022
Merged

OpenAPIEnums feature is beta in 1.24 #32594

merged 1 commit into from
Apr 6, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 29, 2022

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 29, 2022
@netlify
Copy link

netlify bot commented Mar 29, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 9a02c2e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6244356a2fae7b000afac16a

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 29, 2022
@jiahuif
Copy link
Member

jiahuif commented Mar 29, 2022

I thought this was auto updated after code freeze. Am I correct?

@tengqm
Copy link
Contributor Author

tengqm commented Mar 29, 2022

@jiahuif Unfortunately, that is not true. There is no such automation in place and I don't see it will happen any time soon because the feature state is coded in Go source instead of a configuration file. The features are managed by a dozen of SIGs collectively, and there is more than one source of truth. We have to manually maintain this and carry on.

@jiahuif
Copy link
Member

jiahuif commented Mar 29, 2022

Thank you!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2f9c3bcb08e206b828909b07470789b59a855ad6

@mehabhalodiya
Copy link
Contributor

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 29, 2022
@mehabhalodiya
Copy link
Contributor

/assign

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2022
@tengqm tengqm force-pushed the openapienum-beta branch from 27582f8 to 9a02c2e Compare March 30, 2022 10:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2022
@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@kbhawkey
Copy link
Contributor

kbhawkey commented Apr 6, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a9cf06b0d1b38f7b18ffd1c65ad679935244db3

@k8s-ci-robot k8s-ci-robot merged commit 4a13e4c into kubernetes:dev-1.24 Apr 6, 2022
@tengqm tengqm deleted the openapienum-beta branch April 6, 2022 02:16
apelisse
apelisse reviewed Apr 12, 2022
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -155,7 +155,8 @@ different Kubernetes components.
| `NetworkPolicyEndPort` | `true` | Beta | 1.22 | |
| `NodeSwap` | `false` | Alpha | 1.22 | |
| `NodeOutOfServiceVolumeDetach` | `false` | Alpha | 1.24 | |
| `OpenAPIEnums` | `false` | Alpha | 1.23 | |
| `OpenAPIEnums` | `false` | Alpha | 1.23 | 1.23 |
| `OpenAPIEnums` | `false` | Beta | 1.24 | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's enabled by default, if I'm correct. @jiahuif ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. That's a problem. Sending a fix.

@pacoxu pacoxu mentioned this pull request Jan 22, 2025
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse apelisse left review comments

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

@jiahuif jiahuif Awaiting requested review from jiahuif

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

Assignees

@kbhawkey kbhawkey

@jiahuif jiahuif

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.
7 participants
@tengqm @jiahuif @k8s-ci-robot @mehabhalodiya @reylejano @kbhawkey @apelisse