Doc: Add blogpost for honor PV reclaim policy fix #30556

deepakkinni · 2021-11-18T18:58:45Z

This PR is a blog post explaining the change in behavior described in the KEP https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2644-honor-pv-reclaim-policy

cc: @xing-yang @jsafrane

Signed-off-by: Deepak Kinni dkinni@vmware.com

k8s-ci-robot · 2021-11-18T18:58:52Z

Welcome @deepakkinni!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

netlify · 2021-11-18T19:12:06Z

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 5b375a6

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61a7c0174dc46a0007ee3dac

😎 Browse the preview: https://deploy-preview-30556--kubernetes-io-main-staging.netlify.app

sftim

Hi. Here's some partial feedback.

If you take this on board, we'll have more feedback I'm afraid - but it should only be a few things to fix.

content/en/blog/_posts/2021-11-18-honor-pv-reclaim-policy.md

Feedback was incorporated

sftim

Hi. Some important nits, if that's not a contradiction in terms.

content/en/blog/_posts/2021-11-18-persistentvolume-reclaim-improvements.md

xing-yang · 2021-11-19T13:54:02Z

/assign

sftim · 2021-11-20T15:43:46Z

BTW, there is also a v1.23 feature about StatefulSets and PVC reclaim. I suggest scheduling this post to be just before or just after the StatefulSet PVC reclaim article (or even: both on the same day).

content/en/blog/_posts/2021-11-18-persistentvolume-reclaim-improvements.md

deepakkinni · 2021-11-23T19:43:21Z

BTW, there is also a v1.23 feature about StatefulSets and PVC reclaim. I suggest scheduling this post to be just before or just after the StatefulSet PVC reclaim article (or even: both on the same day).

I am not sure how to control the release day.

content/en/blog/_posts/2021-11-18-persistentvolume-reclaim-policy-improvements.md

sftim

Hi Deepak. Here's some more feedback.

I'm not sure about the title. We're not making any changes to reclaim policies; what we're doing is a partial bug fix, and then only for CSI storage integrations.

I preferred the title I proposed before:

Kubernetes 1.23: PersistentVolume reclaim improvements

I'd also consider:

A fix for a bug in PersistentVolume storage reclaim

content/en/blog/_posts/2021-11-18-persistentvolume-reclaim-policy-improvements.md

sftim · 2021-11-23T23:22:36Z

If someone's running a v1.22 cluster and upgrades external-provisioner to v4.0.0 or later, and enable the HonorPVReclaimPolicy feature gate for external-provisioner, is that enough to get the fix? Do they need Kubernetes v1.23 at all?

xing-yang · 2021-11-23T23:42:08Z

Regarding the title, how about "Prevent PV leaks when deleting out of order"?

deepakkinni · 2021-11-24T00:52:33Z

If someone's running a v1.22 cluster and upgrades external-provisioner to v4.0.0 or later, and enable the HonorPVReclaimPolicy feature gate for external-provisioner, is that enough to get the fix? Do they need Kubernetes v1.23 at all?

The fix is applicable only to CSI volumes and migrated volumes after upgrading only the external-provisioner to v4.0.0 or later. However, if they turn off CSI migration and the cluster is at v1.22 the pv controller does not remove the finalizer added by the external-provisioner this will prevent the volumes from being deleted, and the finalizers have to be removed manually by the admin. It can be said that if only CSI volumes are in picture then upgrading external-provisioner is sufficient, if there are csi migrated volumes then the k8s v1.23 is needed.

deepakkinni · 2021-11-24T00:54:19Z

Regarding the title, how about "Prevent PV leaks when deleting out of order"?

@sftim what do you think of this title?

Options:

Kubernetes 1.23: PersistentVolume reclaim improvements
A fix for a bug in PersistentVolume storage reclaim
Prevent PV leaks when deleting out of order

sftim · 2021-11-24T08:21:51Z

I'd go for a slightly longer version: Prevent PersistentVolume leaks when deleting out of order
(bytes are cheap 😉)

sftim · 2021-11-24T08:22:21Z

@deepakkinni let's be clear about what components need the new feature gate turned on in order to get the fix.

deepakkinni · 2021-11-29T20:41:27Z

@deepakkinni let's be clear about what components need the new feature gate turned on in order to get the fix.

It's emphasized in "PV reclaim policy with Kubernetes v1.23"

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md

Signed-off-by: Deepak Kinni <dkinni@vmware.com>

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md

sftim · 2021-12-03T00:32:20Z

Folks, is this article looking technically correct?

xing-yang · 2021-12-03T01:11:17Z

/lgtm

k8s-ci-robot · 2021-12-03T01:11:37Z

LGTM label has been added.

Git tree hash: 5f17ecafa367a65c1dd4673e55eb5819c483dd57

jimangel · 2021-12-06T04:03:22Z

/milestone 1.23
/hold
/cc @jlbutler

karenhchu · 2021-12-06T23:26:07Z

BTW, there is also a v1.23 feature about StatefulSets and PVC reclaim. I suggest scheduling this post to be just before or just after the StatefulSet PVC reclaim article (or even: both on the same day).

I am not sure how to control the release day.

Hello! K8s 1.23 Release Team Comms Lead here. Confirming that the StatefulSet AutoDelete blog post is being updated to be published on 12/16, a day after this blog.

sftim

With technical LGTM in place, let's merge this.

I'll open a PR with proposed fixes.

/hold cancel
/approve

sftim · 2021-12-08T00:53:35Z

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md

@@ -0,0 +1,199 @@
+---
+layout: blog
+title: "Kubernetes 1.23 Prevent PersistentVolume leaks when deleting out of order"


nit:

Suggested change

title: "Kubernetes 1.23 Prevent PersistentVolume leaks when deleting out of order"

title: "Kubernetes 1.23: Prevent PersistentVolume leaks when deleting out of order"

sftim · 2021-12-08T00:53:53Z

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md

+
+**Author:** Deepak Kinni (VMware)
+
+[PersistentVolume](/docs/concepts/storage/persistent-volumes/) (or PVs for short) are


Suggested change

[PersistentVolume](/docs/concepts/storage/persistent-volumes/) (or PVs for short) are

Kubernetes [PersistentVolumes](/docs/concepts/storage/persistent-volumes/) (or PVs for short) are

sftim · 2021-12-08T00:54:50Z

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md

+associated with [Reclaim Policy](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#reclaim-policy).
+The Reclaim Policy is used to determine the actions that need to be taken by the storage


Suggested change

associated with [Reclaim Policy](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#reclaim-policy).

The Reclaim Policy is used to determine the actions that need to be taken by the storage

associated with a [_reclaim policy_](/docs/concepts/storage/persistent-volumes/#reclaim-policy).

That reclaim policy is used to determine the actions that need to be taken by the storage

sftim · 2021-12-08T00:55:03Z

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md

+
+## How did reclaim work in previous Kubernetes releases?
+
+[PersistentVolumeClaim](/docs/concepts/storage/persistent-volumes/#Introduction) (or PVC for short) is


Suggested change

[PersistentVolumeClaim](/docs/concepts/storage/persistent-volumes/#Introduction) (or PVC for short) is

A [PersistentVolumeClaim](/docs/concepts/storage/persistent-volumes/#Introduction) (or PVC for short) is

sftim · 2021-12-08T00:56:19Z

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md

+## How did reclaim work in previous Kubernetes releases?
+
+[PersistentVolumeClaim](/docs/concepts/storage/persistent-volumes/#Introduction) (or PVC for short) is
+a request for storage by a user. A PV and PVC are considered [Bound](/docs/concepts/storage/persistent-volumes/#Binding)


Suggested change

a request for storage by a user. A PV and PVC are considered [Bound](/docs/concepts/storage/persistent-volumes/#Binding)

a request for storage by a user. A PV and PVC are considered

[_bound_](/docs/concepts/storage/persistent-volumes/#binding) to each other

? (note case fix for fragment identifier #binding)

k8s-ci-robot · 2021-12-08T01:00:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/blog/OWNERS~~ [sftim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2021

k8s-ci-robot requested review from onlydole and sftim November 18, 2021 18:59

k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 18, 2021

sftim previously requested changes Nov 18, 2021

View reviewed changes

deepakkinni force-pushed the pv_protect_v1 branch from 8acdd45 to 1abb9b4 Compare November 18, 2021 23:39

sftim reviewed Nov 19, 2021

View reviewed changes

k8s-ci-robot assigned xing-yang Nov 19, 2021

deepakkinni force-pushed the pv_protect_v1 branch from 1abb9b4 to be12a1a Compare November 19, 2021 19:38

xing-yang reviewed Nov 23, 2021

View reviewed changes

jsafrane reviewed Nov 23, 2021

View reviewed changes

content/en/blog/_posts/2021-11-18-persistentvolume-reclaim-improvements.md Outdated Show resolved Hide resolved

deepakkinni force-pushed the pv_protect_v1 branch from be12a1a to 2c8dce7 Compare November 23, 2021 19:42

xing-yang reviewed Nov 23, 2021

View reviewed changes

deepakkinni force-pushed the pv_protect_v1 branch from 2c8dce7 to 143aeaf Compare November 23, 2021 23:09

sftim reviewed Nov 23, 2021

View reviewed changes

deepakkinni force-pushed the pv_protect_v1 branch from 143aeaf to 4c17a22 Compare November 24, 2021 00:45

deepakkinni force-pushed the pv_protect_v1 branch from 4c17a22 to 2d06cdd Compare November 29, 2021 20:40

sftim reviewed Nov 30, 2021

View reviewed changes

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md Outdated Show resolved Hide resolved

deepakkinni force-pushed the pv_protect_v1 branch from 2d06cdd to 9091402 Compare November 30, 2021 19:51

sftim reviewed Nov 30, 2021

View reviewed changes

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md Outdated Show resolved Hide resolved

Doc: Add blogpost for honor PV reclaim policy fix

5b375a6

Signed-off-by: Deepak Kinni <dkinni@vmware.com>

deepakkinni force-pushed the pv_protect_v1 branch from 9091402 to 5b375a6 Compare December 1, 2021 18:33

xing-yang reviewed Dec 2, 2021

View reviewed changes

content/en/blog/_posts/2021-11-18-prevent-persistentvolume-leaks-when-deleting-out-of-order.md Show resolved Hide resolved

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2021

k8s-ci-robot requested a review from jlbutler December 6, 2021 04:03

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2021

k8s-ci-robot added this to the 1.23 milestone Dec 6, 2021

deepakkinni mentioned this pull request Dec 6, 2021

REQUEST: New membership for deepakkinni kubernetes/org#3130

Closed

7 tasks

karenhchu mentioned this pull request Dec 6, 2021

StatefulSet AutoDelete blog post #30596

Merged

sftim reviewed Dec 8, 2021

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021

k8s-ci-robot merged commit 90f6bf7 into kubernetes:main Dec 8, 2021

deepakkinni mentioned this pull request Jul 15, 2024

Blogpost for honor PV reclaim policy fix moving to Beta #46890

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doc: Add blogpost for honor PV reclaim policy fix #30556

Doc: Add blogpost for honor PV reclaim policy fix #30556

deepakkinni commented Nov 18, 2021

k8s-ci-robot commented Nov 18, 2021

netlify bot commented Nov 18, 2021 •

edited

Loading

sftim left a comment

sftim left a comment

xing-yang commented Nov 19, 2021

sftim commented Nov 20, 2021

deepakkinni commented Nov 23, 2021

sftim left a comment

sftim commented Nov 23, 2021

xing-yang commented Nov 23, 2021

deepakkinni commented Nov 24, 2021

deepakkinni commented Nov 24, 2021

sftim commented Nov 24, 2021

sftim commented Nov 24, 2021

deepakkinni commented Nov 29, 2021

sftim commented Dec 3, 2021

xing-yang commented Dec 3, 2021

k8s-ci-robot commented Dec 3, 2021

jimangel commented Dec 6, 2021

karenhchu commented Dec 6, 2021

sftim left a comment

sftim Dec 8, 2021

sftim Dec 8, 2021

sftim Dec 8, 2021

sftim Dec 8, 2021

sftim Dec 8, 2021

k8s-ci-robot commented Dec 8, 2021

	title: "Kubernetes 1.23 Prevent PersistentVolume leaks when deleting out of order"
	title: "Kubernetes 1.23: Prevent PersistentVolume leaks when deleting out of order"


		Author: Deepak Kinni (VMware)

		[PersistentVolume](/docs/concepts/storage/persistent-volumes/) (or PVs for short) are

	[PersistentVolume](/docs/concepts/storage/persistent-volumes/) (or PVs for short) are
	Kubernetes [PersistentVolumes](/docs/concepts/storage/persistent-volumes/) (or PVs for short) are

		associated with [Reclaim Policy](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#reclaim-policy).
		The Reclaim Policy is used to determine the actions that need to be taken by the storage


		## How did reclaim work in previous Kubernetes releases?

		[PersistentVolumeClaim](/docs/concepts/storage/persistent-volumes/#Introduction) (or PVC for short) is

	[PersistentVolumeClaim](/docs/concepts/storage/persistent-volumes/#Introduction) (or PVC for short) is
	A [PersistentVolumeClaim](/docs/concepts/storage/persistent-volumes/#Introduction) (or PVC for short) is

	a request for storage by a user. A PV and PVC are considered [Bound](/docs/concepts/storage/persistent-volumes/#Binding)
	a request for storage by a user. A PV and PVC are considered
	[_bound_](/docs/concepts/storage/persistent-volumes/#binding) to each other

Doc: Add blogpost for honor PV reclaim policy fix #30556

Doc: Add blogpost for honor PV reclaim policy fix #30556

Conversation

deepakkinni commented Nov 18, 2021

k8s-ci-robot commented Nov 18, 2021

netlify bot commented Nov 18, 2021 • edited Loading

sftim left a comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

xing-yang commented Nov 19, 2021

sftim commented Nov 20, 2021

deepakkinni commented Nov 23, 2021

sftim left a comment

Choose a reason for hiding this comment

sftim commented Nov 23, 2021

xing-yang commented Nov 23, 2021

deepakkinni commented Nov 24, 2021

deepakkinni commented Nov 24, 2021

sftim commented Nov 24, 2021

sftim commented Nov 24, 2021

deepakkinni commented Nov 29, 2021

sftim commented Dec 3, 2021

xing-yang commented Dec 3, 2021

k8s-ci-robot commented Dec 3, 2021

jimangel commented Dec 6, 2021

karenhchu commented Dec 6, 2021

sftim left a comment

Choose a reason for hiding this comment

sftim Dec 8, 2021

Choose a reason for hiding this comment

sftim Dec 8, 2021

Choose a reason for hiding this comment

sftim Dec 8, 2021

Choose a reason for hiding this comment

sftim Dec 8, 2021

Choose a reason for hiding this comment

sftim Dec 8, 2021

Choose a reason for hiding this comment

k8s-ci-robot commented Dec 8, 2021

netlify bot commented Nov 18, 2021 •

edited

Loading