Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] translate concept finalizer #30130

Merged
merged 5 commits into from
Oct 24, 2021
Merged

[zh] translate concept finalizer #30130

merged 5 commits into from
Oct 24, 2021

Conversation

mayocream
Copy link
Contributor

@mayocream mayocream commented Oct 18, 2021 •
edited
Loading

ref: #30034

属主引用的名词翻译来自垃圾收集

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2021
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 18, 2021
@mayocream mayocream mentioned this pull request Oct 18, 2021
Closed
7 tasks
@netlify
Copy link

netlify bot commented Oct 18, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: ecb80a2

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/616dac4959fecb00087778ca

😎 Browse the preview: https://deploy-preview-30130--kubernetes-io-main-staging.netlify.app

@netlify
Copy link

netlify bot commented Oct 18, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 8759a59

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6174f3557b2858000800ad24

😎 Browse the preview: https://deploy-preview-30130--kubernetes-io-main-staging.netlify.app

@tengqm
Copy link
Contributor

tengqm commented Oct 20, 2021

/approve
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2021
@mayocream
Copy link
Contributor Author

@howieyuen can you help me get this PR merged?

@mayocream
Copy link
Contributor Author

Look for lgtm

@howieyuen
Copy link
Member

oops, I am late for this, lgtm to me other than minor nit as upstair suggested

@mayocream @tengqm
Update content/zh/docs/reference/glossary/finalizer.md
56b8fc8 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@howieyuen
Copy link
Member

howieyuen commented Oct 24, 2021 •
edited
Loading

Thanks, you need squash these commits into one and push -f to force update
/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 325094d071746ab1508ba611c1579c237f69628d

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit 37508f1 into kubernetes:main Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@pigletfly pigletfly Awaiting requested review from pigletfly

Assignees

@howieyuen howieyuen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayocream @tengqm @k8s-ci-robot @howieyuen