Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod affinity namespaceSelector to beta #28416

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Pod affinity namespaceSelector to beta #28416

merged 1 commit into from
Jun 28, 2021

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Jun 15, 2021

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 15, 2021 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: a30d735

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60c8a52bc4f32c0008b6c688

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 15, 2021
@ahg-g
Copy link
Member Author

ahg-g commented Jun 15, 2021

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jun 15, 2021
@ahg-g ahg-g mentioned this pull request Jun 15, 2021
Closed
12 tasks
@jimangel
Copy link
Member

/unassign
/assign @PI-Victor

sftim
sftim previously requested changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a suggestion to show how to update the feature gate table.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
@sftim sftim dismissed their stale review June 15, 2021 18:08

Feedback addressed

@tengqm
Copy link
Contributor

tengqm commented Jun 16, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@PI-Victor
Copy link
Member

/assign @carlisia

@carlisia
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlisia, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@carlisia
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 046c39fd05d8497db6a502e8b4534b04bfc0af90

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 165247a into kubernetes:dev-1.22 Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@carlisia carlisia

@PI-Victor PI-Victor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
8 participants
@ahg-g @k8sio-netlify-preview-bot @jimangel @tengqm @PI-Victor @carlisia @k8s-ci-robot @sftim