add doc for new flag experimental-keystone-ca-file #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this was sent, the 1.5 branch has been cut. So, this needs to be cherry picked to release-1.5 as well. |
d333620 to
9b7f7f3
Compare
devin-donnelly
suggested changes
Nov 22, 2016
| @@ -367,6 +367,12 @@ option to the API server during startup. The plugin is implemented in | |||
| `plugin/pkg/auth/authenticator/password/keystone/keystone.go` and currently uses | |||
| basic auth to verify used by username and password. | |||
|
|
|||
| If you have configured self-signed certificates for Keystone server, | |||
| `--experimental-keystone-ca-file=SOMEFIlE` option may be needed during the startup | |||
There was a problem hiding this comment.
"If you have configured self-signed certificates for the Keystone server, you may need to set the --experimental-keystone-ca-file=SOMEFILEoption when starting the Kubernetes API server. If you set the option, the Keystone server's certificate is verified by one of the authorities in theexperimental-keystone-ca-file`. Otherwise, the certificate is verified by the host's root Certificate Authority."
|
Some feedback on wording, for clarity and avoiding run-on sentences. |
9b7f7f3 to
b8d8c1b
Compare
|
@devin-donnelly I've already fixed that. Thanks for your review. |
devin-donnelly
approved these changes
Nov 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add doc for this new flag.
This change is