Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax broken highlighting #15830

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Aug 12, 2019

Hugo's highlighter does not understand a variable name with angle
brackets, and breaks the coloring.

This is a fix for #15829

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2019
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 12, 2019
@netlify
Copy link

netlify bot commented Aug 12, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d0dbb0c

https://deploy-preview-15830--kubernetes-io-master-staging.netlify.com

@xiangpengzhao
Copy link
Contributor

/lgtm
@oz123 thanks for the fix!
/assign @MistyHacks @tengqm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
Copy link
Contributor

@mdlinville mdlinville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert your change and replace the < and > characters with [ and ] respectively. The change you have made implies meaning that isn't there (this is syntax for Bash, and isn't appropriate in a YAML file).

Hugo's highlighter does not understand a variable name with angle
brackets, and breaks the coloring.
@oz123 oz123 force-pushed the fix-syntax-highlighting branch from 48682c0 to d0dbb0c Compare August 13, 2019 20:49
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@mdlinville
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2019
@oz123
Copy link
Contributor Author

oz123 commented Aug 13, 2019

Please revert your change and replace the < and > characters with [ and ] respectively. The change you have made implies meaning that isn't there (this is syntax for Bash, and isn't appropriate in a YAML file).

I did replace the variable notation with brackets.

@MistyHacks that was the quickest response ever :-)
10x.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4d14e98 into kubernetes:master Aug 13, 2019
Klaven pushed a commit to Klaven/website that referenced this pull request Aug 15, 2019
Hugo's highlighter does not understand a variable name with angle
brackets, and breaks the coloring.
wahyuoi pushed a commit to wahyuoi/website that referenced this pull request Sep 9, 2019
Hugo's highlighter does not understand a variable name with angle
brackets, and breaks the coloring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants