Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to dismiss banners in the K8s website #39887

Closed
AntonioND opened this issue Mar 9, 2023 · 16 comments · Fixed by #44435
Closed

Add way to dismiss banners in the K8s website #39887

AntonioND opened this issue Mar 9, 2023 · 16 comments · Fixed by #44435
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@AntonioND
Copy link

AntonioND commented Mar 9, 2023

This is a Feature Request

The red banner introduced with #39575 is too intrusive. Most Kubernetes users don't actually care about this deadline, and there is no way to dismiss it.

What would you like to be added

A simple "dismiss" button that sets a cookie to hide the banner in any future visit, like other websites do.

Why is this needed

I'd argue that most users of the website just want to read the documentation, they aren't going to submit images to that registry, so the warning isn't useful.

Comments

This could be reused for future banners.

@AntonioND AntonioND added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Mar 10, 2023

/retitle Add way to dismiss banners in the K8s website

We would implement this for all banners, not just red ones.

@k8s-ci-robot k8s-ci-robot changed the title Add way to dismiss the red banner in the K8s website Add way to dismiss banners in the K8s website Mar 10, 2023
@sftim
Copy link
Contributor

sftim commented Mar 10, 2023

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Mar 10, 2023
@dims
Copy link
Member

dims commented Mar 10, 2023

@AntonioND oh boy! are you in for a ride!!

@dims
Copy link
Member

dims commented Mar 10, 2023

xref: kubernetes/k8s.io#4872

also, here's how i deal with papercuts on the web - https://userstyles.org/help/stylish_chrome

@XDRAGON2002
Copy link
Member

/retitle Add way to dismiss banners in the K8s website

We would implement this for all banners, not just red ones.

Which all banners are you referring to? I'd be willing to take this up.

@sftim
Copy link
Contributor

sftim commented Mar 15, 2023

There's a banner displayed now, it looks like this:
Banner screenshot

Imagine if you could click to acknowledge that you'd read it and didn't want to see it again for a fortnight.

(separately: #39887 (comment) does feel relevant - @AntonioND ruled out taking action as they don't plan to push a container image there, which I think reveals a misunderstanding. I think it's worth repeating banners every couple of weeks in case it helps a message to land better).

@BenTheElder
Copy link
Member

[...] which I think reveals a misunderstanding. [...]

Which ...To clarify for anyone reading: This banner applies to pulling / downloading container images from the Kubernetes project, this banner is aimed at users, not Kubernetes developers. Nobody can push directly to either of these hosts and the change isn't related to pushing / submitting images.

@XDRAGON2002
Copy link
Member

Thanks @sftim and @BenTheElder for the explanation!
I'll take this up and try to resolve this.

/assign

@KhushPatibandha
Copy link
Contributor

@XDRAGON2002 are you working on this issue? I would like to help if you want. Do let me know.

@XDRAGON2002
Copy link
Member

Yes, @KhushPatibandha I'm working on this still, mostly it's completed already, but thanks for the offer!

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2023
@XDRAGON2002 XDRAGON2002 removed their assignment Oct 1, 2023
@mtilson
Copy link
Contributor

mtilson commented Dec 17, 2023

@KhushPatibandha
As XDRAGON2002 seems is evaded, could you please proceed?

@Gauravpadam
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2023
@Gauravpadam
Copy link
Member

I'll help with this, it seems like a good feature

@aj11anuj
Copy link
Member

aj11anuj commented Feb 2, 2024

/sig docs

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.