Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to use the test version of env vars to pin etcd #5920

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Need to use the test version of env vars to pin etcd #5920

merged 1 commit into from
Dec 13, 2017

Conversation

krousey
Copy link
Contributor

@krousey krousey commented Dec 13, 2017

In kuberenetes/cluster/gce/config-test.sh, ETCD_VERSION is overwritten by what ever is in TEST_ETCD_VERSION.

ref kubernetes/kubernetes#56244 and kubernetes/kubernetes#56879

cc @enisoc @BenTheElder

Need to use the test version of env vars to pin etcd
e7d2e72 
In kuberenetes/cluster/gce/config-test.sh, ETCD_VERSION is overwritten
by what ever is in TEST_ETCD_VERSION.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 13, 2017
@krousey
Copy link
Contributor Author

krousey commented Dec 13, 2017

/assign @BenTheElder
/assign @enisoc

BenTheElder
BenTheElder approved these changes Dec 13, 2017
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2017
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, krousey

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2017
@krousey
Copy link
Contributor Author

krousey commented Dec 13, 2017

https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/config-test.sh#L158 for the reason this had to change.

@k8s-ci-robot k8s-ci-robot merged commit 9a73885 into kubernetes:master Dec 13, 2017
This was referenced Dec 13, 2017
Closed
Closed
@BenTheElder BenTheElder mentioned this pull request Dec 13, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@BenTheElder BenTheElder

@enisoc enisoc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krousey @k8s-ci-robot @BenTheElder @enisoc