Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch marker from inside the ci/fast folder #31527

Merged
merged 1 commit into from
Jan 4, 2024
Merged

fetch marker from inside the ci/fast folder #31527

merged 1 commit into from
Jan 4, 2024

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jan 2, 2024

Requires: kubernetes/release#3405
Why/xref: kubernetes/release#3403

/hold till a new version of krel is published and https://testgrid.k8s.io/sig-release-master-blocking#build-master-fast starts pushing to marker inside the ci/fast folder

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/kubetest sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 2, 2024
@upodroid
Copy link
Member Author

upodroid commented Jan 2, 2024

/cc @BenTheElder

@upodroid upodroid force-pushed the fetch-marker-from-new-url branch 2 times, most recently from 3441f42 to e3dea51 Compare January 4, 2024 18:16
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 4, 2024
@upodroid
Copy link
Member Author

upodroid commented Jan 4, 2024

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims January 4, 2024 18:17
@upodroid upodroid force-pushed the fetch-marker-from-new-url branch from e3dea51 to e5449a8 Compare January 4, 2024 18:18
@upodroid
Copy link
Member Author

upodroid commented Jan 4, 2024

The jobs that were using the latest-fast marker have been updated

 mahamed  MAHAALI-M-2PY9  ~  Desktop  Git  k8s-test-infra   fetch-marker-from-new-url  38⬆  1⬇  6⚑  $  grep -r ci\/latest-fast .
./kubetest/extract_k8s.go:      ciFast                 // ci/latest-fast, ci/latest-1.19-fast
./kubetest/extract_test.go:                     "ci/latest-fast",
 mahamed  MAHAALI-M-2PY9  ~  Desktop  Git  k8s-test-infra   fetch-marker-from-new-url  6⚑  $  git log | head -15
commit e5449a816e81b113605cf312ea459e11d281df49
Author: upodroid <upodroid@users.noreply.github.com>
Date:   Thu Jan 4 18:15:56 2024 +0000

    update jobs to use new fast marker location

commit 2bb50c6019624f6fe27a9d442b7420de7d9a4d38
Merge: 2e362a9c70 b85f487874
Author: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com>
Date:   Thu Jan 4 16:40:36 2024 +0100

    Merge pull request #31542 from bart0sh/PR035-revert-crio-commit-updates
    
    Revert crio commit updates

@upodroid upodroid mentioned this pull request Jan 4, 2024
Merged
@dims
Copy link
Member

dims commented Jan 4, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid
Copy link
Member Author

upodroid commented Jan 4, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit a946310 into kubernetes:master Jan 4, 2024
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key gpu-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gpu/gpu-gce.yaml
  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml
  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml
  • key sig-scalability-release-blocking-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-release-blocking-jobs.yaml
  • key sig-storage-gce-config.yaml using file config/jobs/kubernetes/sig-storage/sig-storage-gce-config.yaml

In response to this:

Requires: kubernetes/release#3405
Why/xref: kubernetes/release#3403

/hold till a new version of krel is published and https://testgrid.k8s.io/sig-release-master-blocking#build-master-fast starts pushing to marker inside the ci/fast folder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marseel marseel Awaiting requested review from marseel

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@dims dims Awaiting requested review from dims

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/kubetest area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@upodroid @dims @k8s-ci-robot