Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync image-builder ownership #29667

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Sync image-builder ownership #29667

merged 1 commit into from
Jun 5, 2023

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Jun 1, 2023

The list of maintainers for SIG cluster-lifecycle image-builder jobs had drifted far from the current set of owners, so this syncs it back up.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Jun 1, 2023
@k8s-ci-robot k8s-ci-robot requested review from chases2 and thockin June 1, 2023 15:23
@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jun 1, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Jun 1, 2023

@kkeshavamurthy you should be eligible to join the main Kubernetes GitHub org already since you're a member of kubernetes-sigs (and a project maintainer). You can open an issue at kubernetes/org to do that.

@mboersma mboersma force-pushed the sync-image-builder branch from 380939d to 50123ec Compare June 2, 2023 16:04
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 2, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Jun 2, 2023 •
edited
Loading

/verify-owners

I pared this down so we can move forward, but see kubernetes-sigs/image-builder#1156. Never mind, all owners are members of the Kubernetes org now.

@mboersma mboersma mentioned this pull request Jun 2, 2023
Merged
@mboersma
Copy link
Contributor Author

mboersma commented Jun 2, 2023

/assign @CecileRobertMichon @figo

@AverageMarcus AverageMarcus mentioned this pull request Jun 5, 2023
Merged
@mboersma mboersma force-pushed the sync-image-builder branch from 50123ec to a4523a5 Compare June 5, 2023 16:01
@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2023
CecileRobertMichon
CecileRobertMichon reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@CecileRobertMichon
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@AverageMarcus
Copy link
Member

🤔 Tide seems to be stuck or am I missing something?

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7c80984 into kubernetes:master Jun 5, 2023
@mboersma mboersma deleted the sync-image-builder branch June 5, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@chases2 chases2 Awaiting requested review from chases2

@thockin thockin Awaiting requested review from thockin

Assignees

@figo figo

@jsturtevant jsturtevant

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mboersma @jsturtevant @CecileRobertMichon @k8s-ci-robot @AverageMarcus @figo