cleanup k8s.gcr.io references #28985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't have any images ever published at k8s.gcr.io/test-infra
we aren't supporting kubernetes versions that haven't switched already anymore
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
BenTheElder
commented
Mar 9, 2023
| @@ -18,7 +18,7 @@ periodics: | |||
| testgrid-dashboards: sig-cluster-lifecycle-all | |||
| testgrid-tab-name: periodic-manifest-lists | |||
| testgrid-alert-email: kubernetes-sig-cluster-lifecycle+testgrid@googlegroups.com | |||
| description: "OWNER: sig-cluster-lifecycle; an e2e test for verifying manifest list images at k8s.gcr.io" | |||
| description: "OWNER: sig-cluster-lifecycle; an e2e test for verifying manifest list images at registry.k8s.io" | |||
There was a problem hiding this comment.
this is the only line that matches the existing pull requests, it's a small enough change that it seemed better to just include it.
the other changes in this PR are different and based on closely inspecting each remaining reference.
|
/lgtm |
|
@BenTheElder: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves valid references, which can be tricky to determine.
Remaining:
This is still the correct link
These are the correctly configured jobs for https://github.com/kubernetes/k8s.io/tree/main/k8s.gcr.io
That directory will eventually be wound down, but we're not there yet. When the k8s.io repo is ready, we'll update here as part of that. This is a complex change part of a larger KEP to freeze GCR and switch to registry.k8s.io
This is an old script just printing what images are in use in our CI jobs.
It's still relevant to list if any are coming from k8s.gcr.io, I'd argue more relevant than ever now (since none should be, but someone might on accident)
All of this is configuring CI environments to pull form registry.k8s.io for any k8s.gcr.io images, this requires a reference to the old registry to remap it to the new one and is working as intended.
This label is for https://github.com/kubernetes/k8s.io/tree/main/k8s.gcr.io again.