Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate setup of go-compatibility unit and integration variants #28892

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Automate setup of go-compatibility unit and integration variants #28892

merged 2 commits into from
Mar 2, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 2, 2023 •
edited
Loading

CI changes in support of kubernetes/enhancements#3744

  1. Switches go-compatibility unit and integration variants to always run on release branch PRs (still in optional mode)
  2. Filters out all branches from the master versions so they don't run (skip-branches gets dropped by config-forker)
  3. Adds a --go-version arg to config-forker
  4. Adds ability to perform replacements in container envvar values to config-forker

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 2, 2023
@liggitt liggitt changed the title Go compatibility Automate setup of go-compatibility unit and integration variants Mar 2, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2023

cc @dims @cpanato

@liggitt liggitt force-pushed the go-compatibility branch from f7ce4c1 to 93499e1 Compare March 2, 2023 06:05
@k8s-ci-robot k8s-ci-robot added the area/gubernator Issues or PRs related to code in /gubernator label Mar 2, 2023
@liggitt liggitt mentioned this pull request Mar 2, 2023
Closed
9 tasks
@dims
Copy link
Member

dims commented Mar 2, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8d50285 into kubernetes:master Mar 2, 2023
@k8s-ci-robot
Copy link
Contributor

@liggitt: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key 1.23.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.23.yaml
  • key 1.24.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.24.yaml
  • key 1.25.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.25.yaml
  • key 1.26.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml
  • key integration.yaml using file config/jobs/kubernetes/sig-testing/integration.yaml
  • key make-test.yaml using file config/jobs/kubernetes/sig-testing/make-test.yaml

In response to this:

CI changes in support of kubernetes/enhancements#3744

  1. Switches go-compatibility unit and integration variants to always run on release branch PRs (still in optional mode)
  2. Filters out all branches from the master versions so they don't run (skip-branches gets dropped by config-forker)
  3. Adds a --go-version arg to config-forker
  4. Adds ability to perform replacements in container envvar values to config-forker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cpanato
cpanato reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

late lgtm
thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@justaugustus justaugustus Awaiting requested review from justaugustus

@puerco puerco Awaiting requested review from puerco

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/gubernator Issues or PRs related to code in /gubernator area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liggitt @dims @k8s-ci-robot @cpanato