Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CRI-O job verification presubmit #28755

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Add CRI-O job verification presubmit #28755

merged 1 commit into from
Feb 15, 2023

Conversation

saschagrunert
Copy link
Member

We now add a dedicated verification presubmit job to verify the contents of the jobs/e2e_node/crio directory.

PTAL @haircommander @harche

@saschagrunert
Add CRI-O job verification presubmit
5221a41 
We now add a dedicated verification presubmit job to verify the contents
of the `jobs/e2e_node/crio` directory.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 15, 2023
@dims
Copy link
Member

dims commented Feb 15, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 510886f into kubernetes:master Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-presubmits.yaml using file config/jobs/kubernetes/test-infra/test-infra-presubmits.yaml

In response to this:

We now add a dedicated verification presubmit job to verify the contents of the jobs/e2e_node/crio directory.

PTAL @haircommander @harche

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member

aojea commented Feb 15, 2023

@saschagrunert this job is running and failing on unrelated PRs #28095

@sbueringer
Copy link
Member

Same: #28742 (not quick enough 😂)

@saschagrunert
Copy link
Member Author

Hm, the run_if_changed: '^jobs/e2e_node/crio/' should prevent that. 🤔

@saschagrunert saschagrunert deleted the cri-o-verify-job branch February 15, 2023 13:17
@aojea
Copy link
Member

aojea commented Feb 15, 2023

yeah, that is why I'm asking, I thought the same

@sbueringer
Copy link
Member

Do we have to escape the slashes, e.g. run_if_changed: 'test\/e2e|templates\/test|scripts\/ci-conformance.sh'?

@saschagrunert
Copy link
Member Author

Maybe? Let me try a fix in #28757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes Awaiting requested review from endocrimes

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @dims @k8s-ci-robot @aojea @sbueringer