Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: prepare test jobs for the master->main transition #24131

Merged
merged 1 commit into from
Oct 26, 2021
Merged

kubeadm: prepare test jobs for the master->main transition #24131

merged 1 commit into from
Oct 26, 2021

Conversation

neolit123
Copy link
Member

The kubeadm repository is moving to "main" as the default branch.
kubernetes/kubeadm#2589

The kubeadm-kinder*.yaml changes are automated by the kinder
update-workflows tool.

The mainfests.yaml change is manual.

/config/jobs/kubernetes/kubeadm/ does not require changes, it seems.
That would be true as long as prow runs these presubmit jobs on the
implied default branch.

@neolit123
kubeadm: prepare test jobs for the master->main transition
39b8c44 
The kubeadm repository is moving to "main" as the default branch.

The kubeadm-kinder*.yaml changes are automated by the kinder
update-workflows tool.

The mainfests.yaml change is manual.

/config/jobs/kubernetes/kubeadm/ does not require changes, it seems.
That would be true as long as prow runs these presubmit jobs on the
implied default branch.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2021
@neolit123
Copy link
Member Author

/hold for sync

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2021
@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Oct 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 26, 2021
fabriziopandini
fabriziopandini reviewed Oct 26, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021
@neolit123 neolit123 mentioned this pull request Oct 26, 2021
Closed
6 tasks
@neolit123
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit b8505bf into kubernetes:master Oct 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 26, 2021
@k8s-ci-robot
Copy link
Contributor

@neolit123: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeadm-kinder-addons.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-addons.yaml
  • key kubeadm-kinder-discovery.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-discovery.yaml
  • key kubeadm-kinder-external-ca.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-external-ca.yaml
  • key kubeadm-kinder-external-etcd.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-external-etcd.yaml
  • key kubeadm-kinder-kubelet-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-kubelet-x-on-y.yaml
  • key kubeadm-kinder-patches.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-patches.yaml
  • key kubeadm-kinder-rootless.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-rootless.yaml
  • key kubeadm-kinder-upgrade.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-upgrade.yaml
  • key kubeadm-kinder-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-x-on-y.yaml
  • key kubeadm-kinder.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder.yaml
  • key manifests.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/manifests.yaml

In response to this:

The kubeadm repository is moving to "main" as the default branch.
kubernetes/kubeadm#2589

The kubeadm-kinder*.yaml changes are automated by the kinder
update-workflows tool.

The mainfests.yaml change is manual.

/config/jobs/kubernetes/kubeadm/ does not require changes, it seems.
That would be true as long as prow runs these presubmit jobs on the
implied default branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@justinsb justinsb Awaiting requested review from justinsb

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
3 participants
@neolit123 @k8s-ci-robot @fabriziopandini