fix NPE in blockade #21093
Merged
fix NPE in blockade #21093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiffxp
reviewed
Mar 1, 2021
10ce09e to
5a2a288
Compare
BenTheElder
commented
Mar 1, 2021
| @@ -92,6 +98,12 @@ func TestCalculateBlocks(t *testing.T) { | |||
| config []plugins.Blockade | |||
| expectedSummary summary | |||
| }{ | |||
| { | |||
There was a problem hiding this comment.
this case NPEs if I revert the patch to blockade.go
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks, @BenTheElder! |
nikhita
added a commit
to nikhita/test-infra
that referenced
this pull request
Apr 14, 2021
This reverts commit 354567c. The NPE in blockade was fixed in kubernetes#21093 and ability to recover from panics in plugins in hook was fixed in kubernetes#21410, so we should be safe to reintroduce this config change again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is sufficient anyhow, see: #21090 (comment)
We probably should be doing this even if it's not the whole fix, we should check the actual value we want to gate for nil instead of it's source of truth / a proxy value.