test: restrict the use of specific presets to certain jobs #20946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
693f4bd to
7f5a76d
Compare
spiffxp
reviewed
Feb 23, 2021
There was a problem hiding this comment.
Thank you for doing this!
This is a great start, but doesn't prevent other job definitions from using the secrets defined in these presets.
I think you could blend this with the secret-based logic in TestTrustedJobSecretsRestricted if you add something that gathers secret names from a preset.
faaba2e to
340b50a
Compare
spiffxp
reviewed
Feb 24, 2021
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
2c64f8b to
aba51c2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chewong, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ernest Wong chuwon@microsoft.com
Addresses the second bullet point mentioned in kubernetes/k8s.io#1673 (comment)
/assign @spiffxp