Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prow useful talk from recent Kubecon EU virtual 2020 #19139

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Add Prow useful talk from recent Kubecon EU virtual 2020 #19139

merged 1 commit into from
Sep 9, 2020
+4 −0

Conversation

ArangoGutierrez
Copy link
Contributor

Talk: Going Beyond CI/CD with Prow - Leonardo Di Donato, Sysdig
Kubecon EU virtual 2020

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

@ArangoGutierrez
Add Prow useful talk from recent Kubecon EU virtual 2020
0d73997 
Talk: Going Beyond CI/CD with Prow - Leonardo Di Donato, Sysdig
Kubecon EU virtual 2020

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ArangoGutierrez. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2020
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 6, 2020
@ArangoGutierrez
Copy link
Contributor Author

/assign @fejta

@ArangoGutierrez
Copy link
Contributor Author

@leodido

leodido
leodido approved these changes Sep 7, 2020
View reviewed changes
Copy link

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🌮

@k8s-ci-robot
Copy link
Contributor

@leodido: changing LGTM is restricted to collaborators

In response to this:

Thanks 🌮

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ArangoGutierrez
Copy link
Contributor Author

PING @fejta

hasheddan
hasheddan approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, cjwagner, hasheddan, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4b3d61b into kubernetes:master Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 9, 2020
@ArangoGutierrez ArangoGutierrez mentioned this pull request Dec 14, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodido leodido leodido approved these changes

@cjwagner cjwagner cjwagner approved these changes

@hasheddan hasheddan hasheddan approved these changes

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@fejta fejta

@cjwagner cjwagner

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
6 participants
@ArangoGutierrez @k8s-ci-robot @leodido @cjwagner @hasheddan @fejta