Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prow/cluster/monitoring/README.md #13388

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Add prow/cluster/monitoring/README.md #13388

merged 1 commit into from
Jul 12, 2019

Conversation

hongkailiu
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 10, 2019
@hongkailiu hongkailiu changed the title Add prow/monitoring/README.md [WIP]Add prow/monitoring/README.md Jul 10, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 10, 2019
stevekuznetsov
stevekuznetsov reviewed Jul 10, 2019
View reviewed changes
prow/monitoring/README.md Outdated

A successful deploy will spawn a stack of monitoring for prow in namespace `prow-monitoring`: _prometheus_, _alertmanager_, and _grafana_.

## Add more dashboards
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sub-headings (###) are useful but this one I am not sure adds any value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@hongkailiu hongkailiu force-pushed the readme branch 3 times, most recently from 2d5e7ea to 53a751a Compare July 11, 2019 02:11
@hongkailiu hongkailiu changed the title [WIP]Add prow/monitoring/README.md Add prow/monitoring/README.md Jul 11, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2019
stevekuznetsov
stevekuznetsov reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more comment -- looks like a good start

@hongkailiu
Copy link
Contributor Author

/hold
#13401

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2019
@k8s-ci-robot k8s-ci-robot added the area/prow/bump Updates to the k8s prow cluster label Jul 12, 2019
@hongkailiu
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2019
@hongkailiu hongkailiu changed the title Add prow/monitoring/README.md Add prow/cluster/monitoring/README.md Jul 12, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dbf2a903675ad411f4de3e42c2de77c6686db598

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3ce030d into kubernetes:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/bump Updates to the k8s prow cluster area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongkailiu @k8s-ci-robot @stevekuznetsov