Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable HTTP for Grafana #13099

Closed
wants to merge 1 commit into from
Closed

Disable HTTP for Grafana #13099

wants to merge 1 commit into from

Conversation

cblecker
Copy link
Member

HTTPS 4 lyfe

/assign @stevekuznetsov @hongkailiu

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2019
@cblecker
Copy link
Member Author

/hold
This will need to be deployed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2019
@k8s-ci-robot k8s-ci-robot requested review from cjwagner and matthyx June 20, 2019 03:06
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@matthyx
Copy link
Contributor

matthyx commented Jun 20, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a90a181a539b540926e9884dd82ca4188c1d2597

@hongkailiu
Copy link
Contributor

@cblecker
Just a reminder: #12854 (comment)

@cjwagner
Copy link
Member

cjwagner commented Jun 20, 2019 •
edited
Loading

I definitely agree that we need to avoid using HTTP somehow and I looked into using this annotation, but I think completely disabling port 80 will break cert-manager + letsencrypt.
ref: cert-manager/cert-manager#1366 (comment)

@cblecker
Copy link
Member Author

Yeah, you're right. It'll break. I looked into using Google-managed certificates, but looks like there is a bug where it'll leave the HTTP resources behind anyways: kubernetes/ingress-gce#764

So we will need to maintain HTTP as an option if we want Let's Encrypt... recommend nginx or something as a redirector.

@cblecker cblecker closed this Jun 20, 2019
@cblecker cblecker deleted the disable-http branch June 20, 2019 18:30
@hongkailiu
Copy link
Contributor

JUST for the cross ref:
#12854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjwagner cjwagner Awaiting requested review from cjwagner

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@hongkailiu hongkailiu

@stevekuznetsov stevekuznetsov

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cblecker @k8s-ci-robot @matthyx @hongkailiu @cjwagner @stevekuznetsov