You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The git "version" is really just git describe --tags slightly munged, which omits the git sha1 if the tree is checked out at a tag (e.g. for a release). Our tooling often wants a git sha1, however, so we should probably save it explicitly in a separate field, rather than trying to parse it from the version.
Conveniently the git sha1 is embedded in kubernetes binaries, along with the version; less conveniently, this means we have to parse kubectl version output.
The text was updated successfully, but these errors were encountered:
ixdy
changed the title
save git sha1 in metadata.json
save git sha1 in started.json
Nov 3, 2016
The git "version" is really just
git describe --tags
slightly munged, which omits the git sha1 if the tree is checked out at a tag (e.g. for a release). Our tooling often wants a git sha1, however, so we should probably save it explicitly in a separate field, rather than trying to parse it from the version.Conveniently the git sha1 is embedded in kubernetes binaries, along with the version; less conveniently, this means we have to parse
kubectl version
output.The text was updated successfully, but these errors were encountered: