Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save git sha1 in started.json #987

Closed
ixdy opened this issue Nov 3, 2016 · 0 comments
Closed

save git sha1 in started.json #987

ixdy opened this issue Nov 3, 2016 · 0 comments
Assignees

Comments

@ixdy
Copy link
Member

ixdy commented Nov 3, 2016

The git "version" is really just git describe --tags slightly munged, which omits the git sha1 if the tree is checked out at a tag (e.g. for a release). Our tooling often wants a git sha1, however, so we should probably save it explicitly in a separate field, rather than trying to parse it from the version.

Conveniently the git sha1 is embedded in kubernetes binaries, along with the version; less conveniently, this means we have to parse kubectl version output.

@ixdy ixdy changed the title save git sha1 in metadata.json save git sha1 in started.json Nov 3, 2016
@ixdy ixdy self-assigned this Nov 3, 2016
@fejta fejta closed this as completed Mar 9, 2017
ostromart pushed a commit to ostromart/test-infra that referenced this issue Jul 26, 2019
* Adds fpm

* Update config

* Remove kubeconfig secret
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants