Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting PR boilerplate and labels to improve Release Notes UX #668

Closed
onyiny-ang opened this issue Jun 14, 2019 · 13 comments
Closed

Adjusting PR boilerplate and labels to improve Release Notes UX #668

onyiny-ang opened this issue Jun 14, 2019 · 13 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@onyiny-ang
Copy link
Contributor

onyiny-ang commented Jun 14, 2019

There was some discussion during this release cycle and in slack about collecting more information from each PR in order to improve the user experience for release notes and ease curation for the release notes team.
This boils down to 3 main improvements:

  1. Collecting KEP numbers associated with any PRs that work towards implementing a KEP.
  2. Collecting the Primary-sig or sponsoring SIG associated with each PR to eliminate guess work for the release notes team.
  3. Labeling the PR as a deprecation if it is a deprecation to a dependency.

I would like to propose a subform--or in any case, more detailed release note section of the k/k PR boilerplate that ensures a contributor fills out the Primary SIG section and has a space to associate a KEP # if it is appropriate. A label to indicate deprecations would be great.

@onyiny-ang
Copy link
Contributor Author

/cc @tpepper @justaugustus @jeefy @saschagrunert @lachie83 @jberkus
/sig release

Ideally we would like to have some (or all) of these things available starting in the 1.16 release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jun 14, 2019
@justaugustus
Copy link
Member

/area release-team
/kind design documentation
/milestone v1.16
/priority important-soon
/help

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject kind/design Categorizes issue or PR as related to design. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 30, 2019
@jeefy
Copy link
Member

jeefy commented Aug 12, 2019

/assign @saschagrunert

@saschagrunert
Copy link
Member

I think the only related PR is kubernetes/kubernetes#81278, which we either have to finish or postpone to the next release.

@saschagrunert
Copy link
Member

Please take a look at the two linked PRs, we decided to split up the work a bit more.

@alejandrox1
Copy link
Contributor

/milestone v1.17

@guineveresaenger
Copy link
Contributor

We are waiting on some automation and decisions around proposed labels here.

This won't make the 1.17 milestone.

/milestone v1.18

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 25, 2019
@justaugustus
Copy link
Member

I think we can close the loop on this before 1.17 is out.
/milestone v1.17

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.17 Nov 25, 2019
@saschagrunert
Copy link
Member

I propose that we close this issue now. If we're going to sort the notes by kind then we would not need a primary SIG at all, WDYT?

@justaugustus
Copy link
Member

This needs to stay open until we have a community decision on kind vs SIG.
See here: kubernetes/release#923 (comment)

I'll send a note out next week since US folks are on holiday now.
/remove-help
/unassign
/area release-eng

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 28, 2019
@saschagrunert
Copy link
Member

@justaugustus I think we can close this issue, what do you think?

@alejandrox1
Copy link
Contributor

Just confirmed with @justaugustus that it is cool to close this one
/close

@k8s-ci-robot
Copy link
Contributor

@alejandrox1: Closing this issue.

In response to this:

Just confirmed with @justaugustus that it is cool to close this one
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

7 participants