Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to conntrack-tools as kubelet dependency for RPM's #3712

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 19, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

The alias conntrack-tools should be available for most RPM based distributions, including the mentioned (open)SUSE ones.

Which issue(s) this PR fixes:

Fixes #3711

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Switch to `conntrack-tools` as kubelet package dependency for RPM's.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Aug 19, 2024
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2024
@Muthukumar-Subramaniam
Copy link

Hi @saschagrunert , I have updated a consideration regarding debian based distros in #3711
Please do consider it before this pull request gets merged.

@saschagrunert
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
The alias `conntrack-tools` should be available for most RPM based
distributions, including the mentioned (open)SUSE ones.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

Hi @saschagrunert , I have updated a consideration regarding debian based distros in #3711 Please do consider it before this pull request gets merged.

Thank you, I've updated the PR accordingly.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2024
@saschagrunert saschagrunert changed the title Switch to conntrack-tools as kubelet dependency Switch to conntrack-tools as kubelet dependency for RPM's Aug 19, 2024
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9990dd4 into kubernetes:master Aug 19, 2024
11 checks passed
@saschagrunert saschagrunert deleted the conntrack-tools branch August 19, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants