Fix version comparison for final version after RC #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saschagrunert Sorry for not getting back to you on this one, I'll take a look tomorrow if that's okay. :) |
|
Let me verify something first, sorry! |
xmudrii
requested changes
May 28, 2024
5372030 to
1b4995a
Compare
Fixing the very specific use case of the failing semver comparison mentioned in kubernetes/kubernetes#117115 Follow-up on kubernetes#3223 and kubernetes#3254 Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
1b4995a to
c0d739f
Compare
xmudrii
approved these changes
May 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@saschagrunert Leaving unhold up to you. :) |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixing the very specific use case of the failing semver comparison mentioned in kubernetes/kubernetes#117115
Follow-up on #3223 and #3254
Which issue(s) this PR fixes:
Fixes kubernetes/kubernetes#117115
Special notes for your reviewer:
/assign @xmudrii
/hold
Does this PR introduce a user-facing change?