-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go-runner version in distroless-iptables. #2920
Conversation
/assign @wespanther |
Do we want to do debian-iptables as well while we're at it? It's in |
36bdc95
to
33c99a5
Compare
/lgtm |
/assign @cpanato |
This distroless-iptables image takes a super long time to build (more than an hour from recent runs). I think it's because |
/lgtm since #2909 completed |
I am proposing to have this updated together whenever there is a dependency update in #2909 (comment). Please let me know if there is any concern regarding with this proposal. Thank you |
We should do this earlier actually. We already missed (several?) Golang updates. I talked to @cpanato about this on Slack earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, vinayakankugoyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
kubernetes is updating all go binaries to be built based on go lang versions 1.19.6 or 1.20.1.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?