Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fastforward git user configuration #2503

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 20, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

The recent git auto fast forward jobs fails because of the misconfigured
git user:

https://storage.googleapis.com/kubernetes-jenkins/logs/ci-fast-forward/1516649755411746816/build-log.txt

Step #3: level=info msg="Merging main branch changes into release branch"
Step #3: level=fatal msg="merge main ref: run git merge: command /usr/bin/git merge -X ours origin/master did not succeed: Committer identity unknown\n\n*** Please tell me who you are.\n\nRun\n\n  git config --global user.email \"you@example.com\"\n  git config --global user.name \"Your Name\"\n\nto set your account's default identity.\nOmit --global to set the identity only in this repository.\n\nfatal: unable to auto-detect email address (got 'root@c96ac26cb82d.(none)')\n"
Finished Step #3
ERROR

We now fix this by doing the same configuration like we do in krel
stage and release.

Which issue(s) this PR fixes:

Refers to #2386

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Fixed git configuration in `krel fast-forward`.

The recent git auto fast forward jobs fails because of the misconfigured
git user:

https://storage.googleapis.com/kubernetes-jenkins/logs/ci-fast-forward/1516649755411746816/build-log.txt

```
Step #3: level=info msg="Merging main branch changes into release branch"
Step #3: level=fatal msg="merge main ref: run git merge: command /usr/bin/git merge -X ours origin/master did not succeed: Committer identity unknown\n\n*** Please tell me who you are.\n\nRun\n\n  git config --global user.email \"you@example.com\"\n  git config --global user.name \"Your Name\"\n\nto set your account's default identity.\nOmit --global to set the identity only in this repository.\n\nfatal: unable to auto-detect email address (got 'root@c96ac26cb82d.(none)')\n"
Finished Step #3
ERROR
```

We now fix this by doing the same configuration like we do in krel
stage and release.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2022
@k8s-ci-robot k8s-ci-robot requested a review from onlydole April 20, 2022 07:23
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Apr 20, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 20, 2022
@saschagrunert
Copy link
Member Author

PTAL @cpanato @puerco

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit c969918 into kubernetes:master Apr 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 20, 2022
@saschagrunert saschagrunert deleted the fastforward-git-user branch April 20, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants