Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Go 1.17.6 and 1.16.13 images #2381

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Build Go 1.17.6 and 1.16.13 images #2381

merged 1 commit into from
Jan 17, 2022

Conversation

palnabarun
Copy link
Member

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Build Go 1.17.6 and 1.16.13 images

Which issue(s) this PR fixes:

Part of #2379

Does this PR introduce a user-facing change?

[go] Build Go 1.17.6 and 1.16.13 images

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes needs-priority cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 10, 2022
@palnabarun
Copy link
Member Author

/assign @cpanato @puerco @saschagrunert @Verolop @justaugustus @xmudrii
/cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot requested a review from a team January 10, 2022 13:40
@palnabarun palnabarun mentioned this pull request Jan 10, 2022
Closed
27 tasks
@palnabarun
Copy link
Member Author

/test pull-release-verify

justaugustus
justaugustus requested changes Jan 10, 2022
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

level=error msg="./hack/../dependencies.yaml indicates that golang: after kubernetes/kubernetes update should be at version 1.17.6, but the following files didn't match: images/releng/k8s-ci-builder/Dockerfile, images/releng/k8s-ci-builder/Makefile, images/releng/k8s-ci-builder/variants.yaml"
level=fatal msg="error during command execution: checking local dependencies: Dependencies are not in sync"

ref: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/release/2381/pull-release-verify/1480541001121533952

@palnabarun palnabarun force-pushed the releng/golang-update branch 2 times, most recently from f5aadc9 to 1561a82 Compare January 11, 2022 08:00
@palnabarun
Copy link
Member Author

/test pull-release-image-k8s-cloud-builder

@cpanato
Copy link
Member

cpanato commented Jan 11, 2022

/test pull-release-image-releng-ci

@cpanato
Copy link
Member

cpanato commented Jan 11, 2022

/test pull-release-image-kubepkg

cpanato
cpanato requested changes Jan 11, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if nothing change in the process there are two changes that will be changed only when we merge the go updates in k/k

dependencies.yaml Outdated
@@ -248,7 +248,7 @@ dependencies:
match: \d+.\d+(alpha|beta|rc)?\.?(\d+)?

- name: "golang: after kubernetes/kubernetes update (previous release branches: 1.22, 1.21)"
version: 1.16.12
version: 1.16.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should bump this after the k/k go updates are merged

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha! Thanks.

dependencies.yaml Outdated
@@ -100,7 +100,7 @@ dependencies:
match: go \d+.\d+

- name: "golang: after kubernetes/kubernetes update"
version: 1.17.5
version: 1.17.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should bump this after the k/k go updates are merged

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@palnabarun palnabarun force-pushed the releng/golang-update branch 2 times, most recently from d089e57 to b4d937f Compare January 17, 2022 08:21
@cpanato
Copy link
Member

cpanato commented Jan 17, 2022

/test pull-release-image-releng-ci

@cpanato
Copy link
Member

cpanato commented Jan 17, 2022

/test pull-release-image-kube-cross

@palnabarun
Build Go 1.17.6 and 1.16.13 images
8389d40 
Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@palnabarun palnabarun force-pushed the releng/golang-update branch from b4d937f to 8389d40 Compare January 17, 2022 11:00
@cpanato
Copy link
Member

cpanato commented Jan 17, 2022

/test pull-release-image-go-runner

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 17, 2022 •
edited
Loading

@palnabarun: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-release-image-k8s-cloud-builder b4d937f link true /test pull-release-image-k8s-cloud-builder
pull-release-image-k8s-ci-builder b4d937f link true /test pull-release-image-k8s-ci-builder

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cpanato
Copy link
Member

cpanato commented Jan 17, 2022

/test pull-release-image-go-runner

cpanato
cpanato approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 96d5922 into kubernetes:master Jan 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@cpanato cpanato cpanato approved these changes

@amwat amwat Awaiting requested review from amwat

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@Verolop Verolop

@puerco puerco

@cpanato cpanato

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
8 participants
@palnabarun @cpanato @k8s-ci-robot @justaugustus @saschagrunert @Verolop @puerco @xmudrii