Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dh-systemd package which no longer exists #2325

Merged
merged 2 commits into from
Nov 17, 2021
Merged

remove dh-systemd package which no longer exists #2325

merged 2 commits into from
Nov 17, 2021

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Nov 17, 2021 •
edited
Loading

(folded into debhelper https://bugs.debian.org/822670)

What type of PR is this?

/kind bug

What this PR does / why we need it:

we can't build without this, the package doesn't exist

Slack convo: https://kubernetes.slack.com/archives/CJH2GBF7Y/p1637185646162100?thread_ts=1637138428.119300&cid=CJH2GBF7Y

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- debian packaging: remove dependency on dh-systemd, which is now part of debhelper, update debhelper requirements to minimum version with dh-systemd included (>= 9.20160709)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Nov 17, 2021
@BenTheElder
Copy link
Member Author

There is also this

release/packages/deb/bionic/kubeadm/debian/control

Line 5 in 1e6a233

Build-Depends: curl, ca-certificates, debhelper (>= 8.0.0)

(repeat for each version under templates)

puerco
puerco approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2021
@BenTheElder
Copy link
Member Author

I think maybe we should be updating to Build-Depends: curl, ca-certificates, debhelper (>= 9.20160709)

@justaugustus
Copy link
Member

I think maybe we should be updating to Build-Depends: curl, ca-certificates, debhelper (>= 9.20160709)

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@BenTheElder
Copy link
Member Author

OK this works now, the build previously failed due to the build-depends on dh-systemd still being there.

@BenTheElder BenTheElder changed the title [WIP] remove dh-systemd package which no longer exists remove dh-systemd package which no longer exists Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 17, 2021
@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2021
justaugustus
justaugustus approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, justaugustus, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justaugustus,puerco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco
Copy link
Member

puerco commented Nov 17, 2021

Thank you!!

@k8s-ci-robot k8s-ci-robot merged commit 8742f14 into kubernetes:master Nov 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 17, 2021
@BenTheElder BenTheElder deleted the no-dh-systemd branch November 17, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@puerco puerco puerco approved these changes

@Verolop Verolop Awaiting requested review from Verolop

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@justaugustus justaugustus

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @justaugustus @k8s-ci-robot @puerco