-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match kubernetes-sigs/iptables-wrappers logic #2106
match kubernetes-sigs/iptables-wrappers logic #2106
Conversation
I'm not sure how these are managed now, I'm guessing I should probably change the debian-iptables image version in variants.yaml, but I'm not positive or what to. My guess would be 1.6.2 but I don't see anything covering it. |
Yes, I think bumping to 1.6.2 should be fine. 👍 |
done, I think? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks! Do you wanna do the image promotion and k/k bump or are you fine if a release manager does it? |
I went ahead and filed those 😅 |
see discussion: kubernetes-sigs/kind#2289
What type of PR is this?
/kind bug
What this PR does / why we need it:
Uses the more ideal iptables legacy/nft selection logic to match https://github.com/kubernetes-sigs/iptables-wrappers/
Which issue(s) this PR fixes:
Special notes for your reviewer:
See discussion in kubernetes-sigs/kind#2289
Does this PR introduce a user-facing change?