Add krel stage/release entry methods #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschagrunert
commented
Nov 4, 2020
This cleans-up the previous anago part within the release package as well as the anago subcommand. We now define a new `Stage`/`Release` API inside of `pkg/anago`, which will be later on used by the `krel stage/release` subcommands. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
|
This is ready for review. After that we can move over the first logical bits from |
|
It's really happening now! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This cleans-up the previous anago part within the release package as
well as the anago subcommand.
We now define a new
Stage/ReleaseAPI inside ofpkg/anago, whichwill be later on used by the
krel stage/releasesubcommands.Which issue(s) this PR fixes:
Refers to #1673
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?