Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-cross: Build v1.14.3-1 image #1294

Merged
merged 1 commit into from
May 18, 2020
Merged

kube-cross: Build v1.14.3-1 image #1294

merged 1 commit into from
May 18, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented May 18, 2020 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

go1.14.3 is out: https://golang.org/doc/devel/release.html#go1.14

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-cross: Build v1.14.3-1 image

@justaugustus
kube-cross: Build v1.14.3-1 image
127e2dd 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 18, 2020
@k8s-ci-robot k8s-ci-robot requested review from BenTheElder and listx May 18, 2020 09:19
@justaugustus
Copy link
Member Author

/assign @tpepper @dims @cblecker
cc: @kubernetes/release-engineering
/area dependency
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label May 18, 2020
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels May 18, 2020
@dims
Copy link
Member

dims commented May 18, 2020

/lgtm
/hold if you need any more reviews! feel free to remove hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

Thanks @dims!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3fcf785 into kubernetes:master May 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 18, 2020
This was referenced May 18, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@listx listx Awaiting requested review from listx

Assignees

@dims dims

@cblecker cblecker

@tpepper tpepper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@justaugustus @dims @k8s-ci-robot @cblecker @tpepper