[krel] gcbmgr: Add validation method for GcbmgrOptions #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures the following: - '--stage' and '--release' flags cannot used together - 'rc', 'official' releases cannot run on 'master' - 'alpha', 'beta' releases cannot run on release branches Signed-off-by: Stephen Augustus <saugustus@vmware.com>
hasheddan
approved these changes
May 15, 2020
There was a problem hiding this comment.
/lgtm
/hold in case @saschagrunert wants to take a look before merge
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
This was referenced May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Ensures the following:
--stageand--releaseflags cannot used togetherrc,officialreleases cannot run onmasteralpha,betareleases cannot run on release branchesSigned-off-by: Stephen Augustus saugustus@vmware.com
/assign @saschagrunert
cc: @kubernetes/release-engineering
ref: #1207
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?