Make git.GetRepoURL infallible #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error due to parsing the `DefaultGithubURLBase` is technically not possible and will fail every time if `DefaultGithubURLBase` is wrong. To avoid that, we now manually create the always correct URL and let `GetRepoURL` only return the resulting `string` type. The tests and dependent functions have been adapted as well. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
hasheddan
approved these changes
Mar 25, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
The error due to parsing the
DefaultGithubURLBaseis technically notpossible and will fail every time if
DefaultGithubURLBaseis wrong. Toavoid that, we now manually create the always correct URL and let
GetRepoURLonly return the resultingstringtype. The tests anddependent functions have been adapted as well.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?