gcbmgr: add list build jobs #1194
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,8 +27,12 @@ import ( | |
| "sync" | ||
|
|
||
| "github.com/google/uuid" | ||
| "github.com/olekukonko/tablewriter" | ||
| "github.com/pkg/errors" | ||
| "github.com/sirupsen/logrus" | ||
| "golang.org/x/net/context" | ||
| "google.golang.org/api/cloudbuild/v1" | ||
| "google.golang.org/api/option" | ||
|
|
||
| "k8s.io/release/pkg/command" | ||
| "k8s.io/release/pkg/git" | ||
|
|
@@ -348,3 +352,28 @@ func mergeMaps(maps ...map[string]string) map[string]string { | |
| } | ||
| return out | ||
| } | ||
|
|
||
| func ListJobs(project string, lastJobs int64) error { | ||
| ctx := context.Background() | ||
| opts := option.WithCredentialsFile("") | ||
|
|
||
| service, err := cloudbuild.NewService(ctx, opts) | ||
| if err != nil { | ||
| return errors.Wrap(err, "failed to fetching gcloud credentials... try running \"gcloud auth application-default login\"") | ||
| } | ||
|
|
||
| req, err := service.Projects.Builds.List(project).PageSize(lastJobs).Do() | ||
|
There was a problem hiding this comment. Is there a maximum value for the page size? If yes, what do we do if we’re requesting more jobs? There was a problem hiding this comment. i tried to find in the docs but it does not say anything There was a problem hiding this comment. Fair, do page sizes > 100 work? There was a problem hiding this comment. i did with 301 and returned all 301 last jobs There was a problem hiding this comment. Sounds good to me, thanks for verifying. There was a problem hiding this comment. i think this is not useful but a user can do weird things 😂 There was a problem hiding this comment. it brings the jobs in the future :P but looks like it not fail There was a problem hiding this comment. Follow-up: Normalize (set to default count) any non-positive number. Also, log that we're going to do that |
||
| if err != nil { | ||
| return errors.Wrap(err, "failed to listing the builds") | ||
| } | ||
|
|
||
| table := tablewriter.NewWriter(os.Stdout) | ||
| table.SetHeader([]string{"Start Time", "Finish Time", "Status", "Console Logs"}) | ||
|
|
||
| for _, build := range req.Builds { | ||
| table.Append([]string{strings.TrimSpace(build.StartTime), strings.TrimSpace(build.FinishTime), strings.TrimSpace(build.Status), strings.TrimSpace(build.LogUrl)}) | ||
| } | ||
| table.Render() | ||
|
|
||
| return nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow up I suggest to wrap this in a new struct like we do in the
guthubpackage. :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will review the github package and apply the same in a follow up.
thanks!