Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go dependencies #1142

Merged
merged 2 commits into from
Mar 1, 2020
Merged

Update go dependencies #1142

merged 2 commits into from
Mar 1, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Mar 1, 2020 •
edited
Loading

What type of PR is this?
/kind cleanup
/area dependency

What this PR does / why we need it:

  • github.com/google/go-github/v29 (v29.0.2 --> v29.0.3)
  • github.com/pkg/errors (v0.8.1 --> v0.9.1)
  • github.com/spf13/cobra (v0.0.5 --> v0.0.6)
  • github.com/stretchr/testify (v1.4.0 --> v1.5.1)
  • k8s.io/utils (v0.0.0-20200117235808-5f6fbceb4c31 --> v0.0.0-20200229041039-0a110f9eb7ab)
  • sigs.k8s.io/yaml (v1.1.0 --> v1.2.0)

Signed-off-by: Stephen Augustus saugustus@vmware.com

Special notes for your reviewer:
I'm explicitly leaving the testgrid bump out of this one, as it's already being handled in #1067 and GoogleCloudPlatform/testgrid#90.

Does this PR introduce a user-facing change?:

Update go dependencies
- github.com/google/go-github/v29 (v29.0.2 --> v29.0.3)
- github.com/pkg/errors (v0.8.1 --> v0.9.1)
- github.com/spf13/cobra (v0.0.5 --> v0.0.6)
- github.com/stretchr/testify (v1.4.0 --> v1.5.1)
- k8s.io/utils (v0.0.0-20200117235808-5f6fbceb4c31 --> v0.0.0-20200229041039-0a110f9eb7ab)
- sigs.k8s.io/yaml (v1.1.0 --> v1.2.0)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 1, 2020
cpanato
cpanato approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2020
@cpanato
Copy link
Member

cpanato commented Mar 1, 2020

/test pull-release-test

@justaugustus
Copy link
Member Author

@cpanato -- I'm working on fixing this.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2020
@justaugustus
Update go dependencies
4b6542b 
- github.com/google/go-github/v29 (v29.0.2 --> v29.0.3)
- github.com/pkg/errors (v0.8.1 --> v0.9.1)
- github.com/spf13/cobra (v0.0.5 --> v0.0.6)
- github.com/stretchr/testify (v1.4.0 --> v1.5.1)
- k8s.io/utils (v0.0.0-20200117235808-5f6fbceb4c31
                --> v0.0.0-20200229041039-0a110f9eb7ab)
- sigs.k8s.io/yaml (v1.1.0 --> v1.2.0)

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
cmd/krel: Set root_test.go to expect error when there is no subcommand
f49a574 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Copy link
Member Author

@cpanato -- This should be ready to go now.

saschagrunert
saschagrunert approved these changes Mar 1, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c92b814 into kubernetes:master Mar 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 1, 2020
@justaugustus justaugustus mentioned this pull request Mar 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato cpanato approved these changes

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@justaugustus @cpanato @k8s-ci-robot @saschagrunert