Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CHANGELOG url back to master branch #1137

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Change CHANGELOG url back to master branch #1137

merged 1 commit into from
Mar 1, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 26, 2020 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

In 089f534, we changed the URL to match the tag for the release notes. This now causes that the release notes are not available on that location because they are generated one commit ahead of the actual tag.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

See the links at: https://github.com/kubernetes/kubernetes/releases/tag/v1.18.0-beta.1

Does this PR introduce a user-facing change?:

- Fixed wrong CHANGELOG link not targeting to the release tag any more

/assign @justaugustus

@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 26, 2020
@saschagrunert
Change CHANGELOG url back to master branch
8d9e34f 
In 089f534, we changed the URL to match
the tag for the release notes. This now causes that the release notes
are not available on that location because they are generated one commit
ahead of the actual tag.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 26, 2020
@cpanato cpanato mentioned this pull request Feb 26, 2020
Closed
7 tasks
cpanato
cpanato approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2020
hasheddan
hasheddan approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus
Copy link
Member

/lgtm
/approve

@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Mar 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2020
@k8s-ci-robot k8s-ci-robot merged commit df6d349 into kubernetes:master Mar 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 1, 2020
@saschagrunert saschagrunert deleted the fix-url branch March 1, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@hasheddan hasheddan hasheddan approved these changes

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

Assignees

@justaugustus justaugustus

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @k8s-ci-robot @justaugustus @cpanato @hasheddan