Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove owner from git.CloneOrOpenDefaultGitHubRepoSSH function #1116

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Remove owner from git.CloneOrOpenDefaultGitHubRepoSSH function #1116

merged 1 commit into from
Feb 20, 2020

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We added the variable owner for test reasons, but since we test via a
local bare-copy we do not have a need to set the owner any more.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?:

- Remove `owner` from `git.CloneOrOpenDefaultGitHubRepoSSH` and use the default one (`kubernetes`)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 20, 2020
@saschagrunert
Remove owner from git.CloneOrOpenDefaultGitHubRepoSSH function
0fe0cd7 
We added the variable owner for test reasons, but since we test via a
local bare-copy we do not have a need to set the owner any more.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
hasheddan
hasheddan approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2020
cpanato
cpanato approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3c23261 into kubernetes:master Feb 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 20, 2020
@saschagrunert saschagrunert deleted the rm-owner branch February 20, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@hasheddan hasheddan hasheddan approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @k8s-ci-robot @cpanato @hasheddan