Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[krel] anago: Initial commit #1106

Merged
merged 1 commit into from
May 8, 2020
Merged

[krel] anago: Initial commit #1106

merged 1 commit into from
May 8, 2020

Conversation

justaugustus
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
[krel] anago: Initial commit

Signed-off-by: Stephen Augustus saugustus@vmware.com

Special notes for your reviewer:
This is wildly a copy/pasta WIP. Do not review.

Does this PR introduce a user-facing change?:

[krel] anago: Initial commit

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 17, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020
@justaugustus justaugustus mentioned this pull request Mar 1, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2020
@saschagrunert saschagrunert mentioned this pull request May 8, 2020
Closed
@justaugustus
[krel] anago: Initial commit
8283b02 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2020
@justaugustus justaugustus changed the title [WIP] [krel] anago: Initial commit [krel] anago: Initial commit May 8, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2020
@justaugustus
Copy link
Member Author

/assign @saschagrunert @hasheddan @cpanato
I know it's far from done, but I'd like to get this in to signal intent.
There's a fair chance I won't be able to work on this for a while, so if someone decides to pick it up, I'd like there to be a skeleton for them to work off of.

saschagrunert
saschagrunert approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good starting point where we can iterate on 👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 157f8a3 into kubernetes:master May 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 8, 2020
@saschagrunert saschagrunert mentioned this pull request May 29, 2020
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@hasheddan hasheddan Awaiting requested review from hasheddan

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@justaugustus @k8s-ci-robot @saschagrunert @cpanato @hasheddan