-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify krel Error message when github token env not set #2574
Comments
@DiptoChakrabarty: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@DiptoChakrabarty this makes sense, are you going to work on that and propose a PR? :) |
@saschagrunert Ill keep it open for new contributors , if someone doesnt pick it up in a prolonged period Ill take it up :) |
/assign |
thank you @DiptoChakrabarty 👍 |
Hi @Nawaz027 |
Hi @DiptoChakrabarty |
/assign |
chore(krel): update CLI message for GITHUB_TOKEN #2574
What would you like to be added:
On running the krel tool when no github token env var is set the error message returned is this
validating command line options: Cannot generate release notes if GitHub token is not set
comparing to the release-notes tool the error message for the same case is this, which gives a better idea of the error
neither environment variable
GITHUB_TOKENnor
replayoption is set
It would be good if the krel error returned would be something similar to the release notes where we specify that the Github token is the required environment variable
validating command line options: Cannot generate release notes if GitHub token environment variable is not set
Why is this needed:
Error message sounds better compared to previous error message as it can help debug faster and identify the issue
/good-first-issue
The text was updated successfully, but these errors were encountered: