-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REQUEST: enable travis-ci for kubernetes-client/haskell #651
Comments
@guoshimin our general recommendation in Kubernetes is to use https://github.com/kubernetes/test-infra/tree/master/prow instead of Travis wherever possible. Do you think that Prow could be used in this case? |
I'll look into it. travis-ci is enabled for other repos in the
kubernetes-client org: https://travis-ci.org/kubernetes-client, so I
thought it would be nice to enable it for haskell too.
…On Tue, Mar 26, 2019, 12:40 AM Nikhita Raghunath ***@***.***> wrote:
@guoshimin <https://github.com/guoshimin> our general recommendation in
Kubernetes is to use
https://github.com/kubernetes/test-infra/tree/master/prow instead of
Travis wherever possible. Do you think that Prow could be used in this case?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#651 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALPcHT7LUIiHGbYk3fGl9p438exHEunsks5vac7agaJpZM4cJ7FK>
.
|
Travis is enabled for the kubernetes-client org, AFAIK there are no per-repo settings for us to configure. You may want to contact the members of https://github.com/orgs/kubernetes-client/teams/haskell-admins to have them setup this specific repo That said, we are big fans of community use of prow.k8s.io, it gives us some additional flexibility that travis does not. If you have questions #sig-testing or #prow might be able to help you on slack, or take a look at https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md |
/close |
@spiffxp: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@akshaymankar: You can't reopen an issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@guoshimin: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
It's not enabled for the Haskell repo, as you can see here: https://travis-ci.org/kubernetes-client/haskell
That page is 404 for me. |
My knowledge of travis isn't the best, but I believe one of the admins for the repo needs to activate it. |
I reached out to @brendandburns and @mbohlool to get travis activated on the repo. |
/assign @brendandburns @mbohlool @akshaymankar -- Long term I would definitely push to migrate to prow. We have a significant amount of tooling built around it. |
What does setting up CI on prow look like? I read https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md when @spiffxp suggested it, and I gotta say, I still don't have a clue. |
Prow has three types of jobs - presubmits (run on a PR), postsubmits (run after a merge) and periodics (run at particular intervals). I'm guessing you'd want to setup presubmits for your repo...taking client-go as an example, you'd create a file like this for your repo: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/client-go/client-go-presubmits.yaml
Happy to chat more in real-time on slack about this (I am |
Hi @nikhita, Apologies for silence for so long on this one. I have created a PR for running unit tests for our repo using prow presubmits here: kubernetes/test-infra#15331 There is a question about caching there, I am not sure if it is possible to cache things in prow. Also, I copied all the |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@akshaymankar 👋 Apologies for not responding to your comment earlier. We definitely want to pivot towards using prow and kubernetes/test-infra#15331 looks ready to be merged once the CLA and org membership bits are sorted out.
Yes, you'll need to create issues on this repo and add 2 sponsors as per https://git.k8s.io/community/community-membership.md#member. I'm going to close this issue in favor of kubernetes/test-infra#15331. Please reach out on slack (#sig-contribex, #sig-testing) if you need any help with moving the PR forward. |
Organization or repository
kubernetes-client/haskell
Users affected
N/A
Describe the issue
We would like https://travis-ci.org/kubernetes-client/haskell to be enabled.
The text was updated successfully, but these errors were encountered: