Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: enable travis-ci for kubernetes-client/haskell #651

Closed
guoshimin opened this issue Mar 25, 2019 · 21 comments
Closed

REQUEST: enable travis-ci for kubernetes-client/haskell #651

guoshimin opened this issue Mar 25, 2019 · 21 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@guoshimin
Copy link

Organization or repository

kubernetes-client/haskell

Users affected

N/A

Describe the issue

We would like https://travis-ci.org/kubernetes-client/haskell to be enabled.

@nikhita
Copy link
Member

nikhita commented Mar 26, 2019

@guoshimin our general recommendation in Kubernetes is to use https://github.com/kubernetes/test-infra/tree/master/prow instead of Travis wherever possible. Do you think that Prow could be used in this case?

@guoshimin
Copy link
Author

guoshimin commented Mar 26, 2019 via email

@spiffxp
Copy link
Member

spiffxp commented Mar 26, 2019

Travis is enabled for the kubernetes-client org, AFAIK there are no per-repo settings for us to configure. You may want to contact the members of https://github.com/orgs/kubernetes-client/teams/haskell-admins to have them setup this specific repo

Screen Shot 2019-03-26 at 10 30 43 AM

That said, we are big fans of community use of prow.k8s.io, it gives us some additional flexibility that travis does not. If you have questions #sig-testing or #prow might be able to help you on slack, or take a look at https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md

@spiffxp
Copy link
Member

spiffxp commented Mar 26, 2019

/close
Please /reopen if you feel we have not addressed your question

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
Please /reopen if you feel we have not addressed your question

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Mar 26, 2019

/assign @spiffxp @nikhita
(since we participated)

@akshaymankar
Copy link

/reopen

@k8s-ci-robot
Copy link
Contributor

@akshaymankar: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guoshimin
Copy link
Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Oct 22, 2019
@k8s-ci-robot
Copy link
Contributor

@guoshimin: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guoshimin
Copy link
Author

Travis is enabled for the kubernetes-client org, AFAIK there are no per-repo settings for us to configure.

It's not enabled for the Haskell repo, as you can see here: https://travis-ci.org/kubernetes-client/haskell

You may want to contact the members of https://github.com/orgs/kubernetes-client/teams/haskell-admins to have them setup this specific repo

That page is 404 for me.

@mrbobbytables
Copy link
Member

My knowledge of travis isn't the best, but I believe one of the admins for the repo needs to activate it.

@akshaymankar
Copy link

I reached out to @brendandburns and @mbohlool to get travis activated on the repo.
My email couldn't reach @mbohlool.
@brendandburns said that even he doesn't have rights to activate travis.

@mrbobbytables
Copy link
Member

/assign @brendandburns @mbohlool
As admins on the repo, could one of you ack in thread regarding enabling travis?

@akshaymankar -- Long term I would definitely push to migrate to prow. We have a significant amount of tooling built around it.

@guoshimin
Copy link
Author

What does setting up CI on prow look like? I read https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md when @spiffxp suggested it, and I gotta say, I still don't have a clue.

@nikhita
Copy link
Member

nikhita commented Oct 23, 2019

What does setting up CI on prow look like?

Prow has three types of jobs - presubmits (run on a PR), postsubmits (run after a merge) and periodics (run at particular intervals).

I'm guessing you'd want to setup presubmits for your repo...taking client-go as an example, you'd create a file like this for your repo: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/client-go/client-go-presubmits.yaml

pull-client-go-build is the name of the job, and it uses the golang:1.12 image and runs a go build command in the container. So for your repo, you'd also specify an image that you'd like to use and the commands to run for the job.

Happy to chat more in real-time on slack about this (I am @nikhita on slack as well).

@akshaymankar
Copy link

Hi @nikhita,

Apologies for silence for so long on this one.

I have created a PR for running unit tests for our repo using prow presubmits here: kubernetes/test-infra#15331

There is a question about caching there, I am not sure if it is possible to cache things in prow.

Also, I copied all the OWNERS from the haskell-client repo to prow config directory, now the ci-robot is complaining that some of us are not members of the kubernetes org. I guess we'll have to create issues on this repo to add us there, right?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2020
@akshaymankar
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 18, 2020
@nikhita
Copy link
Member

nikhita commented Jun 15, 2020

@akshaymankar 👋 Apologies for not responding to your comment earlier.

We definitely want to pivot towards using prow and kubernetes/test-infra#15331 looks ready to be merged once the CLA and org membership bits are sorted out.

Also, I copied all the OWNERS from the haskell-client repo to prow config directory, now the ci-robot is complaining that some of us are not members of the kubernetes org. I guess we'll have to create issues on this repo to add us there, right?

Yes, you'll need to create issues on this repo and add 2 sponsors as per https://git.k8s.io/community/community-membership.md#member.

I'm going to close this issue in favor of kubernetes/test-infra#15331. Please reach out on slack (#sig-contribex, #sig-testing) if you need any help with moving the PR forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

9 participants