convert dockerNetworkInspect to a struct #9710

valaparthvi · 2020-11-15T10:54:22Z

minikube start after the changes

➜  minikube git:(issue9690) ✗ ./out/minikube start
I1118 10:57:25.679592    6343 translate.go:89] Failed to load translation file for en: Asset translations/en.json not found
😄  minikube v1.15.0 on Fedora 32
🆕  Kubernetes 1.19.4 is now available. If you would like to upgrade, specify: --kubernetes-version=v1.19.4
✨  Using the kvm2 driver based on existing profile
💾  Downloading driver docker-machine-driver-kvm2:
    > docker-machine-driver-kvm2.sha256: 65 B / 65 B [-------] 100.00% ? p/s 0s
    > docker-machine-driver-kvm2: 13.56 MiB / 13.56 MiB  100.00% 180.70 KiB p/s
💿  Downloading VM boot image ...
    > minikube-v1.15.0.iso.sha256: 65 B / 65 B [-------------] 100.00% ? p/s 0s
    > minikube-v1.15.0.iso: 181.00 MiB / 181.00 MiB  100.00% 1.92 MiB p/s 1m34s
👍  Starting control plane node minikube in cluster minikube
🔄  Restarting existing kvm2 VM for "minikube" ...
🐳  Preparing Kubernetes v1.18.3 on Docker 19.03.12 ...
🔎  Verifying Kubernetes components...
🌟  Enabled addons: storage-provisioner, default-storageclass, dashboard

❗  /usr/bin/kubectl is version 1.10.0+b3b92b2, which may have incompatibilites with Kubernetes 1.18.3.
    ▪ Want kubectl v1.18.3? Try 'minikube kubectl -- get pods -A'
🏄  Done! kubectl is now configured to use "minikube" cluster and "" namespace by default

k8s-ci-robot · 2020-11-15T10:54:30Z

Welcome @valaparthvi!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-11-15T10:54:30Z

Hi @valaparthvi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2020-11-15T10:57:03Z

Can one of the admins verify this patch?

medyagh

thank you for this PR do you mind putting in the PR Descriptipn the After this PR. minikube start output ?

medyagh

Please check the Docker Test failure https://github.com/kubernetes/minikube/pull/9710/checks?check_run_id=1402352846
functional_docker_ubuntu

2020-11-15T11:13:15.4284497Z         	X Exiting due to GUEST_START: Failed to setup kubeconfig: network inspect: error parsing network inspect output: "{\"Name\": \"functional-20201115111211-2491\",\"Driver\": \"bridge\",\"Subnet\": \"192.168.49.0/24\",\"Gateway\": \"192.168.49.1\",\"MTU\": 1500, \"ContainerIPs\": [  \"192.168.49.188/24\",]}\n"

maybe we need to trim the "\n" from the output

020-11-15T11:13:15.3983628Z         ** stderr ** 
2020-11-15T11:13:15.3984110Z         	! Local proxy ignored: not passing HTTP_PROXY=localhost:43067 to docker env.
2020-11-15T11:13:15.4020343Z         	    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 8.00 MiB /    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 16.00 MiB     > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 16.00 MiB     > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 16.00 MiB     > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 20.64 MiB     > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 48.00 MiB     > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 66.67 MiB     > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 95.45 MiB     > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 112.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 130.83 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 136.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 136.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 136.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 136.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 140.72 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 167.53 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 168.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 168.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 168.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 168.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 168.00 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 176.06 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 200.77 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 223.39 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 251.72 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 274.83 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 300.73 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 333.58 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 360.95 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 392.23 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 425.77 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 456.16 MiB    > preloaded-images-k8s-v6-v1.19.4-docker-overlay2-amd64.tar.lz4: 486.35 MiB! Local proxy ignored: not passing HTTP_PROXY=localhost:43067 to docker env.
2020-11-15T11:13:15.4273968Z         	! You appear to be using a proxy, but your NO_PROXY environment does not include the minikube IP (192.168.49.188).
2020-11-15T11:13:15.4282358Z         	E1115 11:13:15.361152    2502 start.go:99] Unable to get host IP: network inspect: error parsing network inspect output: "{\"Name\": \"functional-20201115111211-2491\",\"Driver\": \"bridge\",\"Subnet\": \"192.168.49.0/24\",\"Gateway\": \"192.168.49.1\",\"MTU\": 1500, \"ContainerIPs\": [  \"192.168.49.188/24\",]}\n"
2020-11-15T11:13:15.4284497Z         	X Exiting due to GUEST_START: Failed to setup kubeconfig: network inspect: error parsing network inspect output: "{\"Name\": \"functional-20201115111211-2491\",\"Driver\": \"bridge\",\"Subnet\": \"192.168.49.0/24\",\"Gateway\": \"192.168.49.1\",\"MTU\": 1500, \"ContainerIPs\": [  \"192.168.49.188/24\",]}\n"
2020-11-15T11:13:15.4285484Z         	* 
2020-11-15T11:13:15.4285863Z         	* If the above advice does not help, please let us know: 
2020-11-15T11:13:15.4286883Z         	  - https://github.com/kubernetes/minikube/issues/new/choose
2020-11-15T11:13:15.4287380Z         
2020-11-15T11:13:15.4287632Z         ** /stderr **

valaparthvi · 2020-11-19T15:46:49Z

@medyagh Looks like we're good to go. Although I am not completely happy with the format string

{"Name": "{{.Name}}","Driver": "{{.Driver}}","Subnet": "{{range .IPAM.Config}}{{.Subnet}}{{end}}","Gateway": "{{range .IPAM.Config}}{{.Gateway}}{{end}}","MTU": {{(index .Options "com.docker.network.driver.mtu")}},{{$first := true}} "ContainerIPs": [{{range $k,$v := .Containers }}{{if $first}}{{$first = false}}{{else}}, {{end}}"{{$v.IPv4Address}}"{{end}}]}

I do not understand the purpose of defining first variable but it does help in solving the problem we were facing earlier regarding json unmarshall. Also, the error did not occur because of \n but because of a trailing comma in the ContainerIPs array.

I have tried a few different ways to fix this error but none of them seem elegant enough with regards to the current code.

medyagh · 2020-11-19T20:30:10Z

/ok-to-test

pkg/drivers/kic/oci/network_create.go

minikube-pr-bot · 2020-11-19T20:31:51Z

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9710): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9710/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9710/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9710): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9710/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9710/minikube: exec format error

medyagh · 2020-11-19T22:00:37Z

/retest-this-please

medyagh

thank you @valaparthvi for this PR

k8s-ci-robot · 2020-11-20T22:16:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 15, 2020

k8s-ci-robot requested review from ilya-zuyev and RA489 November 15, 2020 10:54

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 15, 2020

valaparthvi force-pushed the issue9690 branch from 4b1d655 to 205f20d Compare November 15, 2020 11:05

medyagh reviewed Nov 16, 2020

View reviewed changes

valaparthvi force-pushed the issue9690 branch 3 times, most recently from da025fe to a263462 Compare November 19, 2020 06:31

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2020

medyagh reviewed Nov 19, 2020

View reviewed changes

pkg/drivers/kic/oci/network_create.go Show resolved Hide resolved

convert dockerNetworkInspect to a struct

63c186b

valaparthvi force-pushed the issue9690 branch from a263462 to 63c186b Compare November 20, 2020 07:00

medyagh approved these changes Nov 20, 2020

View reviewed changes

medyagh changed the title ~~WIP: convert dockerNetworkInspect to a struct~~ convert dockerNetworkInspect to a struct Nov 20, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 20, 2020

medyagh merged commit 131d724 into kubernetes:master Nov 20, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2020

valaparthvi deleted the issue9690 branch November 21, 2020 07:52

fsladkey mentioned this pull request Nov 30, 2020

Template parsing error when getting docker network #9811

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

convert dockerNetworkInspect to a struct #9710

convert dockerNetworkInspect to a struct #9710

valaparthvi commented Nov 15, 2020 •

edited

Loading

k8s-ci-robot commented Nov 15, 2020

k8s-ci-robot commented Nov 15, 2020

minikube-bot commented Nov 15, 2020

medyagh left a comment

medyagh left a comment •

edited

Loading

valaparthvi commented Nov 19, 2020

medyagh commented Nov 19, 2020

minikube-pr-bot commented Nov 19, 2020

medyagh commented Nov 19, 2020

medyagh left a comment

k8s-ci-robot commented Nov 20, 2020

convert dockerNetworkInspect to a struct #9710

convert dockerNetworkInspect to a struct #9710

Conversation

valaparthvi commented Nov 15, 2020 • edited Loading

k8s-ci-robot commented Nov 15, 2020

k8s-ci-robot commented Nov 15, 2020

minikube-bot commented Nov 15, 2020

medyagh left a comment

Choose a reason for hiding this comment

medyagh left a comment • edited Loading

Choose a reason for hiding this comment

valaparthvi commented Nov 19, 2020

medyagh commented Nov 19, 2020

minikube-pr-bot commented Nov 19, 2020

medyagh commented Nov 19, 2020

medyagh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Nov 20, 2020

valaparthvi commented Nov 15, 2020 •

edited

Loading

medyagh left a comment •

edited

Loading