-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MINIKUBE_IN_STYLE auto-detection for Windows terminal #9127
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 Driver |
kvm2 Driver Times for Minikube (PR 9127): 63.7s 66.1s 63.6s Averages Time Per Log
docker Driver Times for Minikube (PR 9127): 27.5s 28.1s 26.4s Averages Time Per Log
|
Confirmed that color/emoji works fine with the current Windows Terminal build on Windows 10 Pro 10.0.19042. This will not impact most powershell/cmd.exe users for some time, as they do not yet use the latest Windows Terminal. Auto-detection inspired by:
https://stackoverflow.com/questions/59733731/how-do-detect-if-running-in-the-new-windows-terminal