Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template typo #12532

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fix template typo #12532

merged 1 commit into from
Sep 21, 2021

Conversation

spowelljr
Copy link
Member

Related #12509

Problem:
The kubelet was set to use the docker socket if container runtime was set to cri-o due to typo in template.

Before:

$ minikube start --driver=docker --container-runtime=crio
...
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

$ minikube ssh -- cat /etc/systemd/system/kubelet.service.d/10-kubeadm.conf
[Unit]
Wants=docker.socket
...

After:

$ minikube start --driver=docker --container-runtime=crio
...
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default

$ minikube ssh -- cat /etc/systemd/system/kubelet.service.d/10-kubeadm.conf
[Unit]
Wants=crio.service
...

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Sep 21, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 21, 2021
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12532) |
+----------------+----------+---------------------+
| minikube start | 49.8s    | 48.9s               |
| enable ingress | 32.6s    | 34.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 32.3s 33.5s 32.3s 32.4s 32.5s
Times for minikube (PR 12532) ingress: 31.8s 40.8s 33.3s 32.9s 35.4s

Times for minikube (PR 12532) start: 49.4s 48.7s 48.9s 48.6s 48.7s
Times for minikube start: 50.4s 48.5s 51.8s 49.5s 49.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12532) |
+----------------+----------+---------------------+
| minikube start | 22.3s    | 21.9s               |
| enable ingress | 30.2s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.4s 26.4s 34.5s 34.4s 28.5s
Times for minikube (PR 12532) ingress: 27.4s 35.5s 27.4s 34.0s 35.5s

Times for minikube start: 22.9s 22.1s 21.7s 22.8s 21.8s
Times for minikube (PR 12532) start: 22.1s 21.4s 23.0s 21.1s 21.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12532) |
+----------------+----------+---------------------+
| minikube start | 38.9s    | 39.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 32.6s 44.0s 36.8s 43.9s 37.1s
Times for minikube (PR 12532) start: 43.4s 43.6s 24.9s 43.5s 43.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestPause/serial/Pause (gopogh) 5.88 (chart)
Docker_Linux TestPause/serial/VerifyStatus (gopogh) 5.88 (chart)
Docker_Linux TestPause/serial/PauseAgain (gopogh) 7.84 (chart)
Docker_Windows TestStoppedBinaryUpgrade/MinikubeLogs (gopogh) 27.66 (chart)
Docker_Windows TestAddons/Setup (gopogh) 46.10 (chart)
Docker_Windows TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 71.19 (chart)
Docker_Windows TestNetworkPlugins/group/custom-weave/Start (gopogh) 78.05 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/DNS (gopogh) 79.49 (chart)
Docker_Windows TestNetworkPlugins/group/bridge/DNS (gopogh) 82.98 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/DNS (gopogh) 85.71 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 91.06 (chart)
Docker_Linux_containerd TestScheduledStopUnix (gopogh) 100.00 (chart)
Docker_Windows TestCertOptions (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@sharifelgamal sharifelgamal merged commit c0c01d8 into kubernetes:master Sep 21, 2021
@spowelljr spowelljr deleted the fixTemplate branch September 21, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants