-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method for customized box output #11709
Conversation
Hi @dinever. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
} | ||
|
||
// BoxedWithConfig writes a templated message in a box with customized style config to stdout | ||
func BoxedWithConfig(cfg box.Config, st style.Enum, title string, format string, a ...V) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is currently not being used anywhere in the code, and the rule of thumb is not to keep code never used anywhere...how about find a good place/example for this func to be used ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this part of the minikube tips
feature. Please see my proposal: #11696
I was trying to create smaller PRs for easier review. But I can have all the changes in one PR as well if it makes more sense.
Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>
/ok-to-test |
kvm2 driver with docker runtime
Times for minikube start: 49.4s 46.6s 47.7s 48.4s 46.8s Times for minikube ingress: 33.7s 33.8s 34.7s 34.7s 34.6s docker driver with docker runtime
Times for minikube ingress: 30.5s 30.0s 29.5s 31.0s 31.5s Times for minikube start: 22.5s 22.2s 20.8s 21.9s 22.3s docker driver with containerd runtime
Times for minikube start: 31.4s 42.2s 46.5s 43.2s 47.5s |
These are the flake rates of all failed tests on KVM_Linux_containerd.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dinever for this pr look forward to see more
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinever, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of #11207
This gives developers the ability to print out customized box output.
For example: