test: update dashboard URL detection logic for DashboardCmd test #10509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
medyagh
requested changes
Feb 19, 2021
9edea11 to
d9aca3d
Compare
medyagh
approved these changes
Feb 19, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10504
PR #10462 changed logging some info from stderr to stdout. The DashboardCmd test checked stdout for the first line and would use that as the dashboard URL. The change in #10462 made new lines
(
-%20Using%20image%20kubernetesui/dashboard:v2.1.0) output to stdout before the dashboard URL and tried to curl those messages, resulting in the test failing.This PR loops through the stdout messages until it finds a line that start with
httpand uses that as the dashboard URL.