Setting node name via kubeadm extra config leads to a crash

[simleo]

I tried setting the k8s node name with minikube start --extra-config=kubeadm.node-name=foo, but minikube crashed with a timeout. The kubelet logs contain node "minikube" not found, which is probably due to this line in pkg/minikube/bootstrapper/kubeadm/versions.go:

NewUnversionedOption(Kubelet, "hostname-override", constants.DefaultNodeName),

I was able to make it work with:

minikube start --extra-config=kubeadm.node-name=foo --extra-config=kubelet.hostname-override=foo

This took me by surprise, since I was expecting the kubeadm setting to affect the kubelet one in absence of any explicit settings for the latter. Maybe this just needs some extra docs, since the above workaround is available. Or perhaps a top-level --node-name option for minikube start that ensures a consistent handling of the flag in the various components.

[tstromberg]

When possible, we should avoid flags that cause crashes, especially when it's easy to do the right thing. I do like your idea of a --node-name flag to minikube. Help wanted!

[tstromberg]

It's unclear to me whether we should add a mechanism to set the node name outside of the -p (profile) feature. That said, I'm not sure if profiles currently sets a node name or not.

Regardless, we should do better than crashing.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.