Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: TestFunctional/DockerEnv on Windows Docker #10627

Closed
sharifelgamal opened this issue Feb 25, 2021 · 4 comments
Closed

Failing test: TestFunctional/DockerEnv on Windows Docker #10627

sharifelgamal opened this issue Feb 25, 2021 · 4 comments
Assignees
@hetong07
Labels
co/docker-driver Issues related to kubernetes in container help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. os/windows priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v.1.19.0

Comments

@sharifelgamal
Copy link
Collaborator

https://storage.googleapis.com/minikube-builds/logs/10603/fb9f08b/Docker_Windows.html#fail_TestFunctional%2fparallel%2fDockerEnv

This is due to how we run our windows test. We ssh from a linux machine into a windows machine, starting a cmd terminal that then executes a powershell script. minikube docker-env then detects the cmd env and gives us incorrect commands since we're actually in powershell.
@sharifelgamal sharifelgamal added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. os/windows co/docker-driver Issues related to kubernetes in container labels Feb 25, 2021
@sharifelgamal sharifelgamal mentioned this issue Feb 25, 2021
Closed
@priyawadhwa priyawadhwa added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 26, 2021
@medyagh medyagh added this to the v.1.19.0-candidate milestone Feb 26, 2021
@sharifelgamal sharifelgamal added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 1, 2021
@hetong07
Copy link
Contributor

hetong07 commented Mar 5, 2021

seems to be a duplicate issue of #10626

@hetong07
Copy link
Contributor

hetong07 commented Mar 5, 2021

/assign

This was referenced Mar 5, 2021
Merged
Closed
Open
Merged
@k8s-ci-robot
Copy link
Contributor

@hetong07: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@medyagh
Copy link
Member

medyagh commented Mar 30, 2021

this is solved

@medyagh medyagh closed this as completed Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hetong07 hetong07

Labels
co/docker-driver Issues related to kubernetes in container help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. os/windows priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v.1.19.0
Development

No branches or pull requests
5 participants
@medyagh @priyawadhwa @k8s-ci-robot @sharifelgamal @hetong07