Skip to content

Commit

Permalink
Merge pull request #12437 from spowelljr/allowMetallbReconfigure
Browse files Browse the repository at this point in the history
metallb addon: Ask user for config values even if already set
  • Loading branch information
spowelljr authored Sep 8, 2021
2 parents 232f0e3 + 9d940e2 commit 27465c3
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions cmd/minikube/cmd/config/configure.go
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,9 @@ var addonsConfigureCmd = &cobra.Command{
return net.ParseIP(s) != nil
}

if cfg.KubernetesConfig.LoadBalancerStartIP == "" {
cfg.KubernetesConfig.LoadBalancerStartIP = AskForStaticValidatedValue("-- Enter Load Balancer Start IP: ", validator)
}
cfg.KubernetesConfig.LoadBalancerStartIP = AskForStaticValidatedValue("-- Enter Load Balancer Start IP: ", validator)

if cfg.KubernetesConfig.LoadBalancerEndIP == "" {
cfg.KubernetesConfig.LoadBalancerEndIP = AskForStaticValidatedValue("-- Enter Load Balancer End IP: ", validator)
}
cfg.KubernetesConfig.LoadBalancerEndIP = AskForStaticValidatedValue("-- Enter Load Balancer End IP: ", validator)

if err := config.SaveProfile(profile, cfg); err != nil {
out.ErrT(style.Fatal, "Failed to save config {{.profile}}", out.V{"profile": profile})
Expand Down

0 comments on commit 27465c3

Please sign in to comment.